Re: [Bug] 2.5.44-ac2 cdrom eject panic

[Jens Axboe <axboe@suse.de>]

On Fri, Oct 25 2002, Nyk Tarr wrote:
> On Fri, Oct 25, 2002 at 04:48:44PM +0200, Jens Axboe wrote:
> > On Fri, Oct 25 2002, Jens Axboe wrote:
> > > On Fri, Oct 25 2002, Nyk Tarr wrote:
> > > > On Fri, Oct 25, 2002 at 12:39:38PM +0200, Jens Axboe wrote:
> > > > > On Fri, Oct 25 2002, Nyk Tarr wrote:
> > > > > > 
> > > > > > Hi,
> > > > > > 
> > > > > > I got this nice error after doing an 'eject /cdrom'
> > > > > 
> > > > > [snip]
> > > > > 
> > > > > 2.5.44 and thus 2.5.44-acX has seriously broken REQ_BLOCK_PC, so it's no
> > > > > wonder that it breaks hard. Alan, I can sync the sgio patches for you if
> > > > > you want.
> > > > > 
> > > > > Nyk, if you could try
> > > > > 
> > > > > *.kernel.org/pub/linux/kernel/people/axboe/patches/v2.5/2.5.44/sgio-15.bz2
> > > > > 
> > > > > that would be great, thanks.
> > > > 
> > > > This also seems to hang and die. No panic in the logs this time, but
> > > > some stuff scrolling off the screen on console. Sadly I've nothing to
> > > > use as serial console at the mo' but I'll try some other options...
> > > 
> > > Please try sgio-16 from the above location. Ejecting works fine for me,
> > > it even manages to close the tray when I ask it to.
> > 
> > Irk you are on SCSI, yes you need this incremental patch for that to
> > work. Sorry about that, I've put up 16b which contains this.
> 
> That'll teach me to use ide-scsi ^_-.

Indeed, bad bad! You shouldn't need it anymore.

> Working now, thanks. -ac3 applies over the top with 4 offset patches and
> seems to work fine (I can't get various bits of 2.5.44 to compile). I'll
> hammer it some more tomorrow.

I've got a complete patchset for -ac3 as well (19 parts) which I just
sent to Alan, so hopefully -ac4 should be easier to test. I can put it
online somewhere if there's any interest.

But thanks for the report, I appreciate the testing.

-- 
Jens Axboe