Re: 2.5 Problem Report Status

[Toon van der Pas <toon@vanvergehaald.nl>]

On Wed, Oct 23, 2002 at 10:03:51AM -0700, Patrick Mochel wrote:
> 
> ===== drivers/ide/ide.c 1.33 vs edited =====
> --- 1.33/drivers/ide/ide.c	Fri Oct 18 12:44:11 2002
> +++ edited/drivers/ide/ide.c	Wed Oct 23 09:42:27 2002
> @@ -3351,6 +3351,14 @@
>  	return 0;
>  }
>  
> +static void ide_drive_shutdown(struct device * dev)
> +{
> +	ide_drive_t * drive = container_of(dev,ide_drive_t,gendev);
> +	ide_driver_t * drive = drive->driver;

Are you sure you didn't introduce a typo here?  (missing 'r')
Maybe you meant this line to be:

+	ide_driver_t * driver = drive->driver;

> +	if (driver && driver->standby)
> +		driver->standby(drive);
> +}
> +
>  int ide_register_driver(ide_driver_t *driver)
>  {
>  	struct list_head list;
> @@ -3372,6 +3380,7 @@
>  	driver->gen_driver.name = driver->name;
>  	driver->gen_driver.bus = &ide_bus_type;
>  	driver->gen_driver.remove = ide_drive_remove;
> +	driver->gen_driver.shutdown = ide_drive_shutdown;
>  	return driver_register(&driver->gen_driver);
>  }

Regards,
Toon.
-- 
 /"\                             |
 \ /     ASCII RIBBON CAMPAIGN   |  "Who is this General Failure, and
  X        AGAINST HTML MAIL     |   what is he doing on my harddisk?"
 / \