From: Nyk Tarr <nyk@giantx.co.uk>
To: Jens Axboe <axboe@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.44-ac4 scsi CDROMEJECT problem
Date: Mon, 28 Oct 2002 10:54:33 +0000 [thread overview]
Message-ID: <20021028105433.GA18585@giantx.co.uk> (raw)
In-Reply-To: <20021028081507.GD30429@suse.de>
On Mon, Oct 28, 2002 at 09:15:07AM +0100, Jens Axboe wrote:
> On Sun, Oct 27 2002, Nyk Tarr wrote:
> > Hi
> >
> > This patch of Jens Axboe was missing from 2.5.44-ac4. Was this by design
> > or accidental?
>
> Please check blk_do_rq(), it sets rq_dev and rq_disk. So it's indeed
> intentional. Since you ask, do you have problems ejecting?
Yup.
I can only see rq -> rq_dev being set in sg_io(), but then again, you could write the
amount of C I know on a small postage stamp. ^_^
recompiled with the two assignments in under CDROMEJECT it works fine.
Thanks
--
/__
\_|\/
/\
next prev parent reply other threads:[~2002-10-28 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-27 22:31 2.5.44-ac4 scsi CDROMEJECT problem Nyk Tarr
2002-10-28 8:15 ` Jens Axboe
2002-10-28 10:54 ` Nyk Tarr [this message]
2002-10-28 10:57 ` Jens Axboe
2002-10-28 11:41 ` Nyk Tarr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021028105433.GA18585@giantx.co.uk \
--to=nyk@giantx.co.uk \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox