Re: [PATCH] [BK] 0/11 Ext2/3 Updates: Extended attributes, ACL, etc.

[jhf@rivenstone.net (Joseph Fannin)]

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

On Thu, Oct 31, 2002 at 07:47:51PM -0500, Joseph Fannin wrote:
> On Thu, Oct 31, 2002 at 07:24:19PM -0500, Joseph Fannin wrote:
> > On Thu, Oct 31, 2002 at 03:28:29AM -0500, tytso@mit.edu wrote:
> > > Hi Linus,
> > > 
> > > I've updated the ext2/3 patches for 2.5.45.  All of these changes can
> > > also be grabbed by pulling from:
> > > 
> > > 	bk://extfs.bkbits.net/extfs-2.5-update
> 
> [build error]
> 
>     Okay, this looks like it's a problem with the transition to
> kconfig.  I have ext3 built in and ext2 built as a module, but
> CONFIG_FS_MBCACHE=m.  So the problem would be this bit, right?
> 
> # Meta block cache for Extended Attributes (ext2/ext3)
> config FS_MBCACHE
>        tristate
>        depends on EXT2_FS_XATTR || EXT3_FS_XATTR
>        default m if EXT2_FS=m || EXT3_FS=m
>        default y if EXT2_FS=y || EXT3_FS=y
> 
>     Which looks right -- it depends on either ext2 or ext3, and needs
> to be built in if either of ext2 or ext3 are, but if both are modular
> (or one is modular and the other is not built) then FS_MBCACHE should
> be modular.  But it doesn't work.

    Okay, sorry for all the mails.

    "If multiple default statements are visible only the first is
used."

    So the two default lines above need to be reversed.  This seems
backwards to me (the last should be used), but I've said enough.

-- 
Joseph Fannin
jhf@rivenstone.net

"For future reference - don't anybody else try to send patches as vi
scripts, please. Yes, it's manly, but let's face it, so is bungee-jumping
with the cord tied to your testicles." -- Linus Torvalds

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]