From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Frank Davis <fdavis@si.rr.com>
Cc: linux-kernel@vger.kernel.org, ac9410@attbi.com, dperks@ibm.net
Subject: Re: [PATCH] 2.5.45 : drivers/media/video/saa7111.c
Date: Thu, 31 Oct 2002 23:33:07 -0300 [thread overview]
Message-ID: <20021101023306.GF17128@conectiva.com.br> (raw)
In-Reply-To: <Pine.LNX.4.44.0210312217170.963-100000@localhost.localdomain>
Em Thu, Oct 31, 2002 at 10:20:45PM -0500, Frank Davis escreveu:
> Hello all,
> This converts the saa7111 driver's i2c api from i2c-old --> i2c . This
> one was never converted (for some reason). Please review.
> Regards,
> Frank
>
> static struct i2c_driver i2c_driver_saa7111 = {
> "saa7111", /* name */
> - I2C_DRIVERID_VIDEODECODER, /* ID */
> - I2C_SAA7111, I2C_SAA7111 + 1,
> -
> - saa7111_attach,
> + I2C_DRIVERID_SAA7111, /* ID */
> + I2C_DF_NOTIFY,
> + saa7111_probe,
> saa7111_detach,
> saa7111_command
> };
Could you please use the named initializers in C99?
like
static struct i2c_driver i2c_driver_saa7111 = {
.name = "saa7111",
.id = I2C_DRIVERID_VIDEODECODER,
.
.
.
> +static struct i2c_client client_template = {
> + "saa7111_client",
> + -1,
> + 0,
> + 0,
> + NULL,
> + &i2c_driver_saa7111
> +};
ditto, and in this one you can kill all the 0 and the NULL, as it will
be initialized to null if you omit its initializations.
- Arnaldo
prev parent reply other threads:[~2002-11-01 2:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-01 3:20 [PATCH] 2.5.45 : drivers/media/video/saa7111.c Frank Davis
2002-11-01 2:33 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021101023306.GF17128@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=ac9410@attbi.com \
--cc=dperks@ibm.net \
--cc=fdavis@si.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox