public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: chrisl@vmware.com
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Sasha Malchik <sasha@vmware.com>,
	Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: IDE CDROM packet command buffer size restriction.
Date: Fri, 1 Nov 2002 13:10:45 +0100	[thread overview]
Message-ID: <20021101121045.GK8428@suse.de> (raw)
In-Reply-To: <20021101044646.GB8603@vmware.com>

On Thu, Oct 31 2002, chrisl@vmware.com wrote:
> Hi Alan,
> 
> Jens seems too busy to check out this patch. I post it here again
> hopefully to get boarder audiences:

Yes sorry, it's fallen through the cracks.

> VMware try to use the generic packet interface (CDROM_SEND_PACKET)
> for cdrom simulation. There are some packet command used by windows
> can return different data size, depend on the type of CD in the CDROM.
> Current linux kernel will fail the ioctl call if packet command return
> data less than expected.
> 
> ide-scsi driver do not have this problem.
> 
> We make a patch allow kernel return successful and return the actual
> transfer data size. Is it the prefer behavior in this case? If not,
> what is the best way to solve this problem?

The patch does look good, thanks.

> P.S. I am very surprised to find out that, vmware suffers from bugs
> in cdrom driver for years. Developers give up after some attempt to
> submit patches to kernel, it is not easy to make it right at the first
> time. The broken sense data bug should have been fix long time ago if
> they try hard enough.

I can only say resend and resend. It's no secret that I regurlarly loose
patches and don't respond to emails, because there are just so many of
them.

-- 
Jens Axboe


  reply	other threads:[~2002-11-01 12:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-01  4:46 IDE CDROM packet command buffer size restriction chrisl
2002-11-01 12:10 ` Jens Axboe [this message]
2002-11-01 19:11   ` chrisl
2002-11-02  9:10   ` chrisl
2002-11-02  9:20     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021101121045.GK8428@suse.de \
    --to=axboe@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=chrisl@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sasha@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox