Re: [PATCH] 1/2 2.5.45 cleanup & add original copy_ro/from_user

Akira Tsukamoto
2002-11-02T11:58:27Z

On 02 Nov 2002 10:58:35 +0100
Andi Kleen <ak@suse.de> mentioned:
> Akira Tsukamoto <at541@columbia.edu> writes:
>
> > This patch will:
> > 1) If it is not X86_MPENTIUMIII or 4, use the original copy routines,
> > which does not exist in 2.5.45.
>
> First you're ignoring Athlon, which also prefers unrolled copies.
>
> The old user copy functions should then only used when not optimizing for
> modern cpus, but not when the minimum level is 386. And perhaps when
> CONFIG_SMALL is defined.

Yes, it is ignoring Athlon because my patch is basically just clean up and not changing
anything.
If you read the 2.5.45, you will see *2.5.45* is also ignoring Athlon and not using
unrolled copies.

I am working on optimized version for AMD, go over on this patch.
But thank you for your comment, I will consider using CONFIG_SMALL for
putting all the old stuff in it.