From: Jens Axboe <axboe@suse.de>
To: Thomas Molina <tmolina@cox.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: ide-cd still borken for me in 2.5.45
Date: Sat, 2 Nov 2002 15:54:51 +0100 [thread overview]
Message-ID: <20021102145451.GA1820@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0211020847550.876-100000@dad.molina>
On Sat, Nov 02 2002, Thomas Molina wrote:
> On Sat, 2 Nov 2002, Jens Axboe wrote:
>
> > > Well that was quick. 2.5.42 works correctly. The problems begin with
> > > 2.5.43.
> >
> > Ok, so Linus broke it :-)
> >
> > Please boot with this patch, it looks like a command length screwup.
>
> Your patch produced:
>
> hdc: starting 5a, len = 24
ok looks fine, now please try (on top of the other one):
--- /opt/kernel/linux-2.5.45/drivers/ide/ide-cd.c 2002-11-01 11:31:53.000000000 +0100
+++ drivers/ide/ide-cd.c 2002-11-02 15:54:16.000000000 +0100
@@ -906,7 +906,7 @@
ide_set_handler(drive, handler, rq->timeout, cdrom_timer_expiry);
/* Send the command to the device. */
- HWIF(drive)->atapi_output_bytes(drive, rq->cmd, sizeof(rq->cmd));
+ HWIF(drive)->atapi_output_bytes(drive, rq->cmd, 12);
/* Start the DMA if need be */
if (info->dma)
--
Jens Axboe
next prev parent reply other threads:[~2002-11-02 14:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-01 11:55 ide-cd still borken for me in 2.5.45 Thomas Molina
2002-11-01 12:06 ` Jens Axboe
2002-11-01 13:09 ` Thomas Molina
2002-11-02 1:49 ` Thomas Molina
2002-11-02 2:24 ` Thomas Molina
2002-11-02 9:18 ` Jens Axboe
2002-11-02 14:48 ` Thomas Molina
2002-11-02 14:54 ` Jens Axboe [this message]
2002-11-02 15:43 ` Jens Axboe
2002-11-02 18:39 ` Thomas Molina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021102145451.GA1820@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tmolina@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox