Re: Kconfig (qt) -> Gconfig (gtk)

Russell King
2002-11-02T22:00:34Z

On Sat, Nov 02, 2002 at 04:57:31PM -0500, Patrick Finnegan wrote:
> Personally, it makes no difference to me which library is used. I'm
> doubtful I'll use anything other than menuconfig unless it makes my life a
> *whole* lot easier. I'd say 'choose one and get on with it.'

Looking at my menuconfig patch (that's been mailed to lkml numerious
times), the old Menuconfig script and checking mconf.c, it looks like
mconf.c isn't checking for half the errors that the old Menuconfig
script used to / would've been checking with my patch.

Oh, and another thing I've noticed is that mconf does nothing if it
fails to execute lxdialog - it doesn't tell you _why_ it's doing
nothing. It just says something like "Not saving configuration."

The last mailing of my patch was a while ago, so I'll reproduce it
here:

| This patch fixes a failure case in menuconfig which can occur if a kernel
| tree is configured on one architecture with menuconfig, and then attempted
| to be reconfigured on another architecture.
|
| The kernel detects that the binary can't be run on the second architecture
| and correctly returns the appropriate error code. However, the Menuconfig
| script ignores this error and retries endlessly, appearing to hang.
|
| This patch makes menuconfig display a message and exit rather than
| endlessly looping.
|
| scripts/Menuconfig | 20 ++++++++++++++++++++
| 1 files changed, 20 insertions
|
| diff -ur orig/scripts/Menuconfig linux/scripts/Menuconfig
| --- orig/scripts/Menuconfig Sat Oct 12 10:02:17 2002
| +++ linux/scripts/Menuconfig Sat Oct 12 10:45:13 2002
| @@ -909,6 +909,26 @@
| cleanup
| exit 139
| ;;
| + 126|127)
| + stty sane
| + clear
| + cat << EOM
| +
| +There seems to be a problem with the lxdialog companion utility which is
| +built prior to running Menuconfig. lxdialog could not be found, or could
| +not be executed. This can be caused when lxdialog has been built for a
| +different architecture.
| +
| +You should rebuild lxdialog. This can be done by moving to the
| +/usr/src/linux/scripts/lxdialog directory and issuing the "make clean all"
| +command.
| +
| +If the problem persists, you may email the maintainer <mec@shout.net> or
| +post a message to <linux-kernel@vger.kernel.org> for additional assistance.
| +
| +EOM
| + cleanup
| + exit 1
| esac
| done
| }
|

--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux