From: Richard Henderson <rth@twiddle.net>
To: Matthew Wilcox <willy@debian.org>
Cc: Alexander Viro <viro@math.psu.edu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] work around duff ABIs
Date: Sun, 3 Nov 2002 21:10:51 -0800 [thread overview]
Message-ID: <20021103211051.A18863@twiddle.net> (raw)
In-Reply-To: <20021020053147.C5285@parcelfarce.linux.theplanet.co.uk>; from willy@debian.org on Sun, Oct 20, 2002 at 05:31:47AM +0100
On Sun, Oct 20, 2002 at 05:31:47AM +0100, Matthew Wilcox wrote:
> -asmlinkage ssize_t sys_pread64(unsigned int fd, char *buf,
> - size_t count, loff_t pos)
> +#ifdef __BIG_ENDIAN
> +asmlinkage ssize_t sys_pread64(unsigned int fd, char *buf, size_t count,
> + unsigned int high, unsigned int low)
> +#else
> +asmlinkage ssize_t sys_pread64(unsigned int fd, char *buf, size_t count,
> + unsigned int low, unsigned int high)
> +#endif
Broken for actual 64-bit targets.
I'd suggest frobbing the arguments in arch specific code
for those 32-bit targets that do pad 64-bit arguments to
the next even/odd register. I disbelieve you can do
anything cleanly here.
r~
prev parent reply other threads:[~2002-11-04 5:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-20 4:31 [PATCH] work around duff ABIs Matthew Wilcox
2002-10-20 4:45 ` John Levon
2002-10-20 4:51 ` Erik Andersen
2002-10-20 12:51 ` Matthew Wilcox
2002-10-21 12:14 ` Alan Cox
2002-10-22 4:43 ` Erik Andersen
2002-10-22 13:04 ` Matthew Wilcox
2002-10-21 12:13 ` Alan Cox
2002-10-21 13:48 ` Matthew Wilcox
2002-10-21 16:26 ` Alan Cox
2002-11-04 5:10 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021103211051.A18863@twiddle.net \
--to=rth@twiddle.net \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox