Re: [PATCH] 2/2 2.5.45 cleanup & add original copy_ro/from_user

Akira Tsukamoto
2002-11-04T04:30:06Z

On Sat, 02 Nov 2002 20:04:32 -0800
Andrew Morton <akpm@digeo.com> mentioned:
> > From my patch, about the speed:
> > for PIII/4 CPU -> no change. using the same 2.5.45 copy.
> > for old i386 -> more optimal.
> > for Athlon -> 2.5.45 does not use unrolled copy for it either.
>
> OK. Please integrate you patch into the current kernel's usercopy.c.

I will make a revised patch, remove inline and putting inside usercopy.c

> The thing which requires some thought is "should the decision
> be made at compile time or runtime". For Athlon vs Intel
> and i386 vs others, it should be performed at compile time.

I run faster_intel_copy on my Athlon and works OK and much much faster,
so how about grouping CPU type,

generic i386/i486
use org REP MOVSL copy
generic i586
keep as the current 5.45
use revised REP MOVSL copy
generic i686
use revised REP MOVSL copy and unrolled MOVL
if SSE or 3DNOW comes out select them by MPENTIUMIII/4/K7