From: Russell King <rmk@arm.linux.org.uk>
To: Miles Bader <miles@gnu.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.46: drivers/mtd/mtdblock.c won't compile -- misordered declaration
Date: Tue, 5 Nov 2002 09:18:17 +0000 [thread overview]
Message-ID: <20021105091817.A18670@flint.arm.linux.org.uk> (raw)
In-Reply-To: <buobs54ipzx.fsf@mcspd15.ucom.lsi.nec.co.jp>; from miles@lsi.nec.co.jp on Tue, Nov 05, 2002 at 01:45:22PM +0900
On Tue, Nov 05, 2002 at 01:45:22PM +0900, Miles Bader wrote:
> [This is a repost of my earlier message, since the problem doesn't seem
> to have been fixed in 2.5.46; could someone please look at this?
> I don't think it should be controversial...]
>
> When I compile 2.5.45, I get the following errors:
It'll be fixed in 2.5.47 - Linus has already incorporated the following.
I just missed 2.5.46 by a few hours (because I normally send my requests
to Linus at around 11pm - Midnight GMT.)
# --------------------------------------------
# 02/11/04 rmk@flint.arm.linux.org.uk 1.896
# [MTD] Fix mtdblock.c build error
# Move spin_unlock_irq() down one line.
# --------------------------------------------
diff -Nru a/drivers/mtd/mtdblock.c b/drivers/mtd/mtdblock.c
--- a/drivers/mtd/mtdblock.c Mon Nov 4 22:56:17 2002
+++ b/drivers/mtd/mtdblock.c Mon Nov 4 22:56:17 2002
@@ -394,8 +394,8 @@
while (!blk_queue_empty(&mtd_queue)) {
struct request *req = elv_next_request(&mtd_queue);
- spin_unlock_irq(mtd_queue.queue_lock);
struct mtdblk_dev **p = req->rq_disk->private_data;
+ spin_unlock_irq(mtd_queue.queue_lock);
mtdblk = *p;
res = 0;
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
prev parent reply other threads:[~2002-11-05 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-01 5:24 2.5.45: drivers/mtd/mtdblock.c won't compile -- misordered declaration Miles Bader
2002-11-05 4:45 ` 2.5.46: " Miles Bader
2002-11-05 9:18 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021105091817.A18670@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=miles@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox