From: Joe Thornber <joe@fib011235813.fsnet.co.uk>
To: linux-lvm@sistina.com
Cc: Bernd Eckenfels <ecki@lina.inka.de>,
dm@uk.sistina.com, linux-kernel@vger.kernel.org
Subject: Re: [linux-lvm] Re: [patch] make device mapper compile on 2.5.4x
Date: Tue, 12 Nov 2002 08:58:08 +0000 [thread overview]
Message-ID: <20021112085808.GB1308@reti> (raw)
In-Reply-To: <Pine.GSO.4.21.0211111821210.29617-100000@steklov.math.psu.edu>
On Mon, Nov 11, 2002 at 06:23:00PM -0500, Alexander Viro wrote:
>
>
> On Mon, 11 Nov 2002, Bernd Eckenfels wrote:
>
> > - set_device_ro(dm_kdev(md), 0/*(param->flags & DM_READONLY_FLAG)*/);
> > + bdev = bdget(kdev_t_to_nr(dm_kdev(md)));
> > + if (!bdev)
> > + return -ENXIO;
> > + set_device_ro(bdev, (param->flags & DM_READONLY_FLAG));
> > + bdput(bdev);
>
> That is simply wrong. set_device_ro() works only on opened block_device.
> Correct fix is to use set_disk_ro() and it's already in the tree (1.830
> on bkbits).
And I have sent the patch for this 3 times now.
- Joe
prev parent reply other threads:[~2002-11-12 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-11 22:53 [patch] make device mapper compile on 2.5.4x Bernd Eckenfels
2002-11-11 23:23 ` Alexander Viro
2002-11-12 8:58 ` Joe Thornber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021112085808.GB1308@reti \
--to=joe@fib011235813.fsnet.co.uk \
--cc=dm@uk.sistina.com \
--cc=ecki@lina.inka.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-lvm@sistina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox