From: Rusty Russell <rusty@rustcorp.com.au>
To: Anders Gustafsson <andersg@0x63.nu>
Cc: linux-kernel@vger.kernel.org, lord@sgi.com
Subject: Re: 2.5-bk AT_GID clash
Date: Wed, 13 Nov 2002 04:16:56 +1100 [thread overview]
Message-ID: <20021112172423.91C0C2C2DA@lists.samba.org> (raw)
In-Reply-To: Your message of "Tue, 12 Nov 2002 02:18:58 BST." <20021112011858.GB19877@gagarin>
In message <20021112011858.GB19877@gagarin> you write:
> Hi,
>
> the new module-api making module.h including elf.h have exposed a name clash
> in xfs:
>
> include/linux/elf.h:175:#define AT_GID 13 /* real gid */
> fs/xfs/linux/xfs_vnode.h:547:#define AT_GID 0x00000008
>
> Can one be renamed?
Probably should be. I don't use AT_GID from memory, maybe somewhere
else in the kernel is.
> Maybe module.h shouldn't be including elf.h, that afaik is needed by the
> arch-specific module loaders and not by all modules. A split into
> module.h for the modules and moduleloader.h for the arch-spec-loaders?
This might be OK too, but in practice I don't think much will be in
moduleloader.h: asm/module.h only really defines struct
mod_arch_specific, which is embedded in struct module, and struct
module needs to be exposed for those inlines...
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2002-11-12 17:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-12 1:18 2.5-bk AT_GID clash Anders Gustafsson
2002-11-12 17:16 ` Rusty Russell [this message]
2002-11-12 17:33 ` Steve Lord
2002-11-12 18:07 ` Rusty Russell
2002-11-13 7:34 ` Nathan Scott
2002-11-13 11:17 ` linux/elf.h vs linux/module.h [was: 2.5-bk AT_GID clash] Anders Gustafsson
2002-11-14 1:53 ` Rusty Russell
2002-11-13 22:37 ` 2.5-bk AT_GID clash Paul Mackerras
2002-11-12 18:07 ` Christoph Hellwig
2002-11-12 22:50 ` Anders Gustafsson
2002-11-14 6:44 ` Rusty Russell
2002-11-14 13:26 ` Anders Gustafsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021112172423.91C0C2C2DA@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=andersg@0x63.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=lord@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox