From: Alan Cox <alan@redhat.com>
To: pavel@ucw.cz (Pavel Machek)
Cc: torvalds@transmeta.com,
linux-kernel@vger.kernel.org (kernel list),
alan@redhat.com
Subject: Re: Kill obsolete and unused suspend/resume code from IDE
Date: Tue, 12 Nov 2002 13:01:53 -0500 (EST) [thread overview]
Message-ID: <200211121801.gACI1ro25294@devserv.devel.redhat.com> (raw)
In-Reply-To: <20021112175154.GA6881@elf.ucw.cz> from "Pavel Machek" at Nov 12, 2002 06:51:54 PM
> This code in ide is obsolete and unused. I have followup patch to
> integrate IDE into sysfs. Please apply,
The code is not obsolete, it is not unused
> + do_idedisk_standby(drive);
> if ((drive->id->cfs_enable_2 & 0x3000) && drive->wcache)
> if (do_idedisk_flushcache(drive))
> printk (KERN_INFO "%s: Write Cache FAILED Flushing!\n",
What locking rules are you using here ?
Linus please reject this patch. Its just getting in the way of actually
fixing the IDE code properly.
next prev parent reply other threads:[~2002-11-12 17:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-12 17:51 Kill obsolete and unused suspend/resume code from IDE Pavel Machek
2002-11-12 18:01 ` Alan Cox [this message]
2002-11-13 13:42 ` Pavel Machek
2002-11-13 14:32 ` Alan Cox
2002-11-13 14:17 ` Pavel Machek
[not found] ` <1037126927.9383.5.camel@irongate.swansea.linux.org.uk>
2002-11-13 13:46 ` Pavel Machek
2002-11-13 14:13 ` Pavel Machek
2002-11-13 14:50 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200211121801.gACI1ro25294@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox