From: Rusty Russell <rusty@rustcorp.com.au>
To: Zwane Mwaikambo <zwane@holomorphy.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [PATCH][2.5] Remove BUG in cpu_up
Date: Wed, 13 Nov 2002 20:33:11 +1100 [thread overview]
Message-ID: <20021113093843.5C5142C253@lists.samba.org> (raw)
In-Reply-To: Your message of "Tue, 12 Nov 2002 22:42:07 CDT." <Pine.LNX.4.44.0211122236270.24523-100000@montezuma.mastecende.com>
In message <Pine.LNX.4.44.0211122236270.24523-100000@montezuma.mastecende.com>
you write:
> ret = __cpu_up(cpu);
> if (ret != 0)
> goto out_notify;
> - if (!cpu_online(cpu))
> - BUG();
> +
> + if (!cpu_online(cpu)) {
> + ret = -EIO;
> + goto out_notify;
> + }
Err, no. If __cpu_up(cpu) succeeded, that means the cpu should bloody
well be online!
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2002-11-13 9:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-13 3:42 [PATCH][2.5] Remove BUG in cpu_up Zwane Mwaikambo
2002-11-13 9:33 ` Rusty Russell [this message]
2002-11-13 13:17 ` Zwane Mwaikambo
2002-11-14 1:56 ` Rusty Russell
2002-11-14 3:18 ` Zwane Mwaikambo
2002-11-14 5:08 ` Rusty Russell
2002-11-14 22:24 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021113093843.5C5142C253@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=zwane@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox