From: Matthew Wilcox <willy@debian.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Matthew Wilcox <willy@debian.org>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org, mochel@osdl.org
Subject: Re: [PATCH] eliminate pci_dev name
Date: Thu, 14 Nov 2002 18:34:41 +0000 [thread overview]
Message-ID: <20021114183441.D30392@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <3DD3EB3D.8050606@pobox.com>; from jgarzik@pobox.com on Thu, Nov 14, 2002 at 01:28:13PM -0500
On Thu, Nov 14, 2002 at 01:28:13PM -0500, Jeff Garzik wrote:
> Patch looks pretty good to me... seems like the obvious (and useful)
> cleanup.
>
> You should increase DEVICE_NAME_SIZE in include/linux/device.h from 80
> to 90, though. I assume you don't want to take the other option, which
> is to audit every use and all the id strings to make sure they're short
> enough. In fact, IIRC, device name increased in size due to some really
> long PCI names, so I think '90' will wind up the preferred value in any
> case.
I didn't break anything that wasn't already broken.
- strcpy(dev->dev.name, dev->name);
Who wants a smack?
--
Revolutions do not require corporate support.
next prev parent reply other threads:[~2002-11-14 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-14 17:10 [PATCH] eliminate pci_dev name Matthew Wilcox
2002-11-14 18:28 ` Jeff Garzik
2002-11-14 18:34 ` Matthew Wilcox [this message]
2002-11-14 18:36 ` Linus Torvalds
2002-11-14 18:44 ` Matthew Wilcox
2002-11-14 19:22 ` Linus Torvalds
2002-11-14 20:44 ` Ingo Oeser
2002-11-16 23:47 ` Matthew Wilcox
2002-11-14 19:10 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021114183441.D30392@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox