From: Matthew Wilcox <willy@debian.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Matthew Wilcox <willy@debian.org>,
linux-kernel@vger.kernel.org, mochel@osdl.org
Subject: Re: [PATCH] eliminate pci_dev name
Date: Thu, 14 Nov 2002 18:44:31 +0000 [thread overview]
Message-ID: <20021114184431.E30392@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.44.0211141031500.3323-100000@home.transmeta.com>; from torvalds@transmeta.com on Thu, Nov 14, 2002 at 10:36:03AM -0800
On Thu, Nov 14, 2002 at 10:36:03AM -0800, Linus Torvalds wrote:
> Actually, I think we should do the reverse (for testing), and make the
> name be something small like 8 bytes, and make sure that everybody who
> writes the name uses strncpy() and snprintf() instead of just blindly
> writing whatever is in the database.
>
> Otherwise we'll always end up having fragile magic constants.
>
> Anybody willing to do that cleanup?
Sure, I can do that. That leads me to think that maybe we should
delete name from struct device and just use the one in struct kobject
(which is already a mere 16 bytes). But if we're going to go as far
down as the kobject... that has a dentry. And dentrys have names.
So how about eliminating that too and just creating a dentry with the
almost infinitely long name?
Maybe that's too much at this stage of the game.
--
Revolutions do not require corporate support.
next prev parent reply other threads:[~2002-11-14 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-14 17:10 [PATCH] eliminate pci_dev name Matthew Wilcox
2002-11-14 18:28 ` Jeff Garzik
2002-11-14 18:34 ` Matthew Wilcox
2002-11-14 18:36 ` Linus Torvalds
2002-11-14 18:44 ` Matthew Wilcox [this message]
2002-11-14 19:22 ` Linus Torvalds
2002-11-14 20:44 ` Ingo Oeser
2002-11-16 23:47 ` Matthew Wilcox
2002-11-14 19:10 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021114184431.E30392@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox