public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Shawn Starr <spstarr@sh0n.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] Fix drivers/acpi/sleep.c compile error if swsusp is disabled
Date: Thu, 14 Nov 2002 23:59:23 +0100	[thread overview]
Message-ID: <20021114225922.GA1334@elf.ucw.cz> (raw)
In-Reply-To: <200211132304.03608.spstarr@sh0n.net>

Hi!

> Hi, this should fix this compile problem (if this is correct).
> 
> Please apply.

It would silently do nothing, that's bad.

Could you make it so that CONFIG_ACPI_SLEEP is not selectable without
CONFIG_SOFTWARE_SUSPEND  and move CONFIG_SOFTWARE_SUSPEND into "power
managment" submenu?
								Pavel
>                 break;
> 
>         case ACPI_STATE_S2:
> +#ifdef CONFIG_SOFTWARE_SUSPEND
>         case ACPI_STATE_S3:
>                 do_suspend_lowlevel(0);
> +#endif
>                 break;
>         }
>         local_irq_restore(flags);
> 
> 

-- 
When do you have heart between your knees?

  reply	other threads:[~2002-11-15 11:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-14  4:04 [RFC][PATCH] Fix drivers/acpi/sleep.c compile error if swsusp is disabled Shawn Starr
2002-11-14 22:59 ` Pavel Machek [this message]
2002-11-16  5:12   ` Shawn Starr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021114225922.GA1334@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spstarr@sh0n.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox