From: John Levon <levon@movementarian.org>
To: Corey Minyard <cminyard@mvista.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
"Heater, Daniel (IndSys, GEFanuc,
VMIC)" <Daniel.Heater@gefanuc.com>,
"'Zwane Mwaikambo'" <zwane@holomorphy.com>,
Dipankar Sarma <dipankar@gamebox.net>,
linux-kernel@vger.kernel.org
Subject: Re: NMI handling rework for x86
Date: Fri, 15 Nov 2002 05:12:07 +0000 [thread overview]
Message-ID: <20021115051207.GA29779@compsoc.man.ac.uk> (raw)
In-Reply-To: <3DD47858.3060404@mvista.com>
On Thu, Nov 14, 2002 at 10:30:16PM -0600, Corey Minyard wrote:
> Since a lot of things are hacking into this code (lkcd, kdb, oprofile,
> nmi watchdog, and now my IPMI watchdog pretimeout), it would be very
> nice to get their junk out of this code and allow them to bind in
> nicely, and allow binding from modules.
I've just noticed you haven't fixed the watchdog vs. oprofile case. You
pass in the handled flag to the NMI watchdog handler, but you ignore the
value and always do the perfctr reset. You /must/ only do the reset if
handled == false, or you'll screw up oprofile when it's running.
also, the diff would be much easier to read as a separate "mv nmi.c
nmi_watchdog.c" then diff against that
regards
john
next prev parent reply other threads:[~2002-11-15 5:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-15 4:30 NMI handling rework for x86 Corey Minyard
2002-11-15 4:40 ` Zwane Mwaikambo
2002-11-15 6:10 ` Dipankar Sarma
2002-11-15 7:40 ` Zwane Mwaikambo
2002-11-15 8:13 ` Dipankar Sarma
2002-11-15 8:18 ` Zwane Mwaikambo
2002-11-15 8:50 ` Dipankar Sarma
2002-11-15 17:41 ` John Levon
2002-11-15 22:46 ` Zwane Mwaikambo
2002-11-15 5:12 ` John Levon [this message]
2002-11-15 5:19 ` John Levon
2002-11-15 14:13 ` Corey Minyard
2002-11-15 17:48 ` John Levon
2002-11-15 19:00 ` Corey Minyard
2002-11-15 19:28 ` John Levon
2002-11-15 19:35 ` Corey Minyard
2002-11-17 2:00 ` John Levon
2002-11-17 2:31 ` Zwane Mwaikambo
2002-11-18 16:48 ` Corey Minyard
2002-11-18 15:34 ` Corey Minyard
2002-11-15 5:20 ` Randy.Dunlap
2002-11-15 9:50 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021115051207.GA29779@compsoc.man.ac.uk \
--to=levon@movementarian.org \
--cc=Daniel.Heater@gefanuc.com \
--cc=cminyard@mvista.com \
--cc=dipankar@gamebox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=zwane@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox