From: Vojtech Pavlik <vojtech@suse.cz>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: [patch] Input - fix open counting in usbmouse/usbkbd [8/13]
Date: Fri, 15 Nov 2002 09:14:22 +0100 [thread overview]
Message-ID: <20021115091422.G16779@ucw.cz> (raw)
In-Reply-To: <20021115091347.F16779@ucw.cz>; from vojtech@suse.cz on Fri, Nov 15, 2002 at 09:13:47AM +0100
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
'bk pull bk://linux-input.bkbits.net/linux-input' should work as well.
===================================================================
ChangeSet@1.786.54.5, 2002-10-24 12:56:59+02:00, vojtech@suse.cz
Fix open counting in usbkbd.c and usbmouse.c in case the irq urb
submit fails. Bug spotted by Thiemo Seufer.
usbkbd.c | 4 +++-
usbmouse.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
===================================================================
diff -Nru a/drivers/usb/input/usbkbd.c b/drivers/usb/input/usbkbd.c
--- a/drivers/usb/input/usbkbd.c Fri Nov 15 08:31:06 2002
+++ b/drivers/usb/input/usbkbd.c Fri Nov 15 08:31:06 2002
@@ -163,8 +163,10 @@
return 0;
kbd->irq->dev = kbd->usbdev;
- if (usb_submit_urb(kbd->irq, GFP_KERNEL))
+ if (usb_submit_urb(kbd->irq, GFP_KERNEL)) {
+ kbd->open--;
return -EIO;
+ }
return 0;
}
diff -Nru a/drivers/usb/input/usbmouse.c b/drivers/usb/input/usbmouse.c
--- a/drivers/usb/input/usbmouse.c Fri Nov 15 08:31:06 2002
+++ b/drivers/usb/input/usbmouse.c Fri Nov 15 08:31:06 2002
@@ -86,8 +86,10 @@
return 0;
mouse->irq->dev = mouse->usbdev;
- if (usb_submit_urb(mouse->irq, GFP_KERNEL))
+ if (usb_submit_urb(mouse->irq, GFP_KERNEL)) {
+ mouse->open--;
return -EIO;
+ }
return 0;
}
===================================================================
This BitKeeper patch contains the following changesets:
1.786.54.5
## Wrapped with gzip_uu ##
begin 664 bkpatch16379
M'XL(`+JBU#T``\V56V^;,!B&K_&O^*3>M.H"/G'*E"KK<5.K+4K7Z\J`"2P%
M,C#9NK'_/D/24]JL335-XRAC^]7KC^>%+;BH9-DWYL47)<,$;<'[HE)]HZHK
M:88_='M<%+IM)44FK>4H*YA::3ZK%=+](Z'"!.:RK/H&,=GM$W4]DWUC?'1R
M<?9NC-!@``>)R"?R7"H8#)`JRKFXBJJA4,E5D9NJ%'F5227,L,B:VZ$-Q9CJ
MW28NP[;3$`=SMPE)1(C@1$:8<L_A:&ELN+2],I_H400SQGA#&<$<'0(Q7<\Q
M;6[:@*E%L$4Y$-JWG;[M[V+:QQA6-&&70@^C??B[S@]0",?I=RAF,H>PJ'.5
MYA-(<ZBK8!I$9@@BC]I&5G0^VJY05!)4(B$MOT)=!EJBJH,L51"+]*HR8;^>
M0#4KE)(1!-?P.4EE5L"YK&-9FN@4**/$1J.[-X)Z&VX(88'1WC/%B,JT!</2
M]JV[)=RK#,?$;6SF.Z1A3B"E9V,W"&/!8KE:_P=B'7VKDHO7;#LV;PCS?+:I
MO:[<J^8X=SW:L-B/.?9<%LE8"!R\S-R=X#UKW.74[_*P?L[S`7F]=12)N<R&
MI8P2H1YI/>E=GQYWJ59T"':[]%#R*#=\76X8],B_R4W+]J*^GZ!7?NL.S>KH
M#Z5^!?F'Q'&`H`_MC2(CC6%;JUTN(GBI\[BME7M[.IQOX.1X='EZ-/YX=+:S
M`S^1871=K>E>[VTKX6HEX]=Z'FYBORD1&V4-34HY&4[+0B3KB7B@Z!.'$N90
MUA#],6$=$\3[7YE8?`Y>PL1RD:^APO-;*/3U:28ZY754+#MON?#Q$HN;OVF8
5R'!:U=E`B)`SX4;H-US`1&"Z!P``
`
end
next prev parent reply other threads:[~2002-11-15 8:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-15 8:08 [patch] Input - Rescan serio only if valid reason [1/13] Vojtech Pavlik
2002-11-15 8:09 ` [patch] Input - Add a missing \n [2/13] Vojtech Pavlik
2002-11-15 8:10 ` [patch] Input - Add a wheel to Logitech Wheel Mouse [3/13] Vojtech Pavlik
2002-11-15 8:11 ` [patch] Input - Only check for SET_LEDS in atkbd.c when really needed [4/13] Vojtech Pavlik
2002-11-15 8:12 ` [patch] Input - Probe for Synaptics Touchpads so that other probes don't confuse them [5/13] Vojtech Pavlik
2002-11-15 8:12 ` [patch] Input - Remove dead logibusmouse.h [6/13] Vojtech Pavlik
2002-11-15 8:13 ` [patch] Input - Back out bad 'fix' in hid-input.c [7/13] Vojtech Pavlik
2002-11-15 8:14 ` Vojtech Pavlik [this message]
2002-11-15 8:14 ` [patch] Input - fix typo in amikbd.c [9/13] Vojtech Pavlik
2002-11-15 8:15 ` [patch] Input - handle return values from interface_register() [10/13] Vojtech Pavlik
2002-11-15 8:16 ` [patch] Input - Add defaults for ATKBD et al [11/13] Vojtech Pavlik
2002-11-15 8:17 ` [patch] Input - Add more descriptive comments to input/serio [12/13] Vojtech Pavlik
2002-11-15 8:18 ` [patch] Input - Add "PS/2 keyboard" to ATKBD help [13/13] Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021115091422.G16779@ucw.cz \
--to=vojtech@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox