Re: PC-9800 patch for 2.5.47-ac4: not merged yet (14/15) serial

[Andrey Panin <pazke@orbita1.ru>]

[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]

On Птн, Ноя 15, 2002 at 10:35:18 +0900, Osamu Tomita wrote:
> Andrey Panin wrote:
> > 
> > On ????????, ??????????15, 2002 at 10:06:46 +0900, Osamu Tomita wrote:
> > > This is for serial port and onboard modem support.
> > 
> > > @@ -376,7 +378,12 @@
> > >                           ((port->min == 0x2f8) ||
> > >                            (port->min == 0x3f8) ||
> > >                            (port->min == 0x2e8) ||
> > > +#ifndef CONFIG_PC9800
> > >                            (port->min == 0x3e8)))
> > > +#else
> > > +                          (port->min == 0x3e8) ||
> > > +                          (port->min == 0x8b0)))
> > > +#endif
> > >                               return 0;
> > >       }
> > 
> > Why 0x8b0 should be added here ?
> > Is it one of default iobase value for C-bus PNP modems ?
> Yes. C-bus PNP modems use this default value. And old modem
> card is hard wired to this iobase.

Ok. But IMHO this way is better (check order doesn't matter here):

			((port->min == 0x2f8) ||
			 (port->min == 0x3f8) ||
			 (port->min == 0x2e8) ||
                         (port->min == 0x3e8) ||
#ifdef CONFIG_PC9800
                         (port->min == 0x8b0) ||
#endif

                         (port->min == 0x3e8)))
                              return 0;
	}

-- 
Andrey Panin            | Embedded systems software developer
pazke@orbita1.ru        | PGP key: wwwkeys.eu.pgp.net

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]