From: Rusty Russell <rusty@rustcorp.com.au>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PARAM 2/4
Date: Sat, 16 Nov 2002 10:17:37 +1100 [thread overview]
Message-ID: <20021115231840.2FE3D2C09A@lists.samba.org> (raw)
In-Reply-To: Your message of "Fri, 15 Nov 2002 17:51:48 CDT." <3DD57A84.2070805@pobox.com>
In message <3DD57A84.2070805@pobox.com> you write:
> 1) I note you ignored Matthew Wilcox's example of module_init being used
> in two different ways.
I didn't see it, sorry. Valid point.
> 2) "proper", converted-to-Rusty-style driver code is going to have
>
> MODULE_blah
> MODULE_foo
> MODULE_bar
> PARAM
>
> You think that looks good??
Hmm... OK, you've swayed me. I'll redo the patch.
> PARAM is ugly in drivers, and way too generic.
Well, we completely disagree on this point. If I was starting from
scratch, MODULE_AUTHOR would simply be AUTHOR(), etc.
But I've always opposed this kind of "neatening" as the ultimite in
stupidity, so consistency wins.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2002-11-15 23:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-15 22:26 [PATCH] PARAM 2/4 Rusty Russell
2002-11-15 22:51 ` Jeff Garzik
2002-11-15 23:17 ` Rusty Russell [this message]
2002-11-16 7:15 ` Willy Tarreau
2002-11-17 18:00 ` Linus Torvalds
2002-11-17 18:21 ` Rusty Russell
2002-11-17 18:29 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021115231840.2FE3D2C09A@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox