From: Arnd Bergmann <arndb@de.ibm.com>
To: "J.E.J. Bottomley" <James.Bottomley@steeleye.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Scsi <linux-scsi@vger.kernel.org>
Subject: Re: [RFC][PATCH] move dma_mask into struct device
Date: Sat, 16 Nov 2002 21:46:46 +0100 [thread overview]
Message-ID: <200211162145.44304.arndb@de.ibm.com> (raw)
In-Reply-To: <200211161812.gAGICj604696@localhost.localdomain>
On Saturday 16 November 2002 19:12, J.E.J. Bottomley wrote:
> No...look at what you've done. Now SCSI has to know about every bus type
> on every architecture; that's an extreme layering violation.
> architecture/bus types are generally only defined for the arch (PCI being
> the exception), so now the additions have to be #ifdef'd just so it will
> compile..
Right, the definitions for how to get the dma_mask out of a bus specific
device don't belong into the generic header file.
Still, each host driver knows how to find the dma_mask if any, so
it can easily set the field in the Scsi_Host. Existing pci host
adapter drivers can keep using scsi_set_pci_device(), others
can just as well do it themselves.
Arnd <><
next prev parent reply other threads:[~2002-11-16 18:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <arndb@de.ibm.com>
2002-11-16 17:23 ` [RFC][PATCH] move dma_mask into struct device Arnd Bergmann
2002-11-16 15:33 ` J.E.J. Bottomley
2002-11-16 18:26 ` Arnd Bergmann
2002-11-16 17:01 ` J.E.J. Bottomley
2002-11-16 19:56 ` Arnd Bergmann
2002-11-16 18:12 ` J.E.J. Bottomley
2002-11-16 20:46 ` Arnd Bergmann [this message]
2002-11-15 20:34 J.E.J. Bottomley
2002-11-16 0:19 ` Mike Anderson
2002-11-16 14:48 ` J.E.J. Bottomley
2002-11-16 20:33 ` Patrick Mansfield
2002-11-17 15:07 ` J.E.J. Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200211162145.44304.arndb@de.ibm.com \
--to=arndb@de.ibm.com \
--cc=James.Bottomley@steeleye.com \
--cc=ibm.com@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox