From: Adrian Bunk <bunk@fs.tum.de>
To: Rusty Russell <rusty@rustcorp.com.au>, greg@kroah.com
Cc: linux-kernel@vger.kernel.org
Subject: [2.5 patch] fix compile error in usb-serial.c
Date: Mon, 18 Nov 2002 15:39:09 +0100 [thread overview]
Message-ID: <20021118143909.GG11952@fs.tum.de> (raw)
drivers/usb/serial/usb-serial.c in 2.5.48 fails to compile with the
following error:
<-- snip -->
...
gcc -Wp,-MD,drivers/usb/serial/.usb-serial.o.d -D__KERNEL__ -Iinclude
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=k6
-Iarch/i386/mach-generic -nostdinc -iwithprefix include -DKBUILD_BASENAME=usb_serial
-DKBUILD_MODNAME=usbserial -c -o drivers/usb/serial/usb-serial.o
drivers/usb/serial/usb-serial.c
drivers/usb/serial/usb-serial.c: In function `serial_read_proc':
drivers/usb/serial/usb-serial.c:842: dereferencing pointer to incompletetype
make[3]: *** [drivers/usb/serial/usb-serial.o] Error 1
<-- snip -->
Is the following patch correct?
--- linux-2.5.48/drivers/usb/serial/usb-serial.c.old 2002-11-18 15:16:57.000000000 +0100
+++ linux-2.5.48/drivers/usb/serial/usb-serial.c 2002-11-18 15:24:39.000000000 +0100
@@ -839,7 +839,7 @@
length += sprintf (page+length, "%d:", i);
if (serial->type->owner)
- length += sprintf (page+length, " module:%s", serial->type->owner->name);
+ length += sprintf (page+length, " module:%s", module_name(serial->type->owner));
length += sprintf (page+length, " name:\"%s\"", serial->type->name);
length += sprintf (page+length, " vendor:%04x product:%04x", serial->vendor, serial->product);
length += sprintf (page+length, " num_ports:%d", serial->num_ports);
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next reply other threads:[~2002-11-18 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-18 14:39 Adrian Bunk [this message]
2002-11-18 21:35 ` [2.5 patch] fix compile error in usb-serial.c Greg KH
2002-11-18 22:20 ` Adrian Bunk
2002-11-18 23:26 ` Rusty Russell
2002-11-19 2:22 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021118143909.GG11952@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox