public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "J.E.J. Bottomley" <James.Bottomley@steeleye.com>
To: Jens Axboe <axboe@suse.de>
Cc: Andrew Morton <akpm@digeo.com>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org,
	James Bottomley <James.Bottomley@SteelEye.com>
Subject: Re: scsi in 2.5.48
Date: Mon, 18 Nov 2002 09:05:34 -0600	[thread overview]
Message-ID: <200211181505.gAIF5am02001@localhost.localdomain> (raw)
In-Reply-To: Message from Jens Axboe <axboe@suse.de>  of "Mon, 18 Nov 2002 14:56:14 +0100." <20021118135614.GA834@suse.de>

akpm@digeo.com said:
> > Andrew Morton wrote:
> 
> > Appears to be DOA.  Just a simple mke2fs hangs in get_request_wait().
> This makes it work again. 

That can't be entirely right, because we can't exit the request function with 
pending requests and something like an unplugged queue to start them.  It will 
work for the adaptec because the prep defer is caused by the huge queue depth 
running us out of command blocks, so the queues would get re-run by a 
returning command.  If the failure were caused by zero outstanding commands, 
this would hang the system forever.

axboe@suse.de said:
> Right fix would be something ala: 

That looks about right.  On returning I/O we need to unplug and restart.

However, with regard to Andrew's problem, how can the queue plug indefinitely? 
 I thought it was guaranteed to be unplugged and run eventually?

James



  reply	other threads:[~2002-11-18 14:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-18  9:14 scsi in 2.5.48 Andrew Morton
2002-11-18  9:45 ` Andrew Morton
2002-11-18 13:56   ` Jens Axboe
2002-11-18 15:05     ` J.E.J. Bottomley [this message]
2002-11-19  6:31     ` Andrew Morton
2002-11-19 13:06     ` William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200211181505.gAIF5am02001@localhost.localdomain \
    --to=james.bottomley@steeleye.com \
    --cc=akpm@digeo.com \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox