* [PATCH] 2.5.47 Minor bug in non-fatal machine check
@ 2002-11-15 18:56 Pallipadi, Venkatesh
2002-11-18 17:39 ` Dave Jones
0 siblings, 1 reply; 2+ messages in thread
From: Pallipadi, Venkatesh @ 2002-11-15 18:56 UTC (permalink / raw)
To: linux-kernel; +Cc: Dave Jones, torvalds
A minor bug in nonfatal mcheck code. Non fatal machine check won't find any MCE faults in CONFIG_SMP and num_online_cpus==1 case, as mce_checkregs() will not be called at all. Attached patch should fix this.
Thanks,
-Venkatesh
--- linux-2.5.47/arch/i386/kernel/cpu/mcheck/non-fatal.c.org Wed Nov 13 13:17:57 2002
+++ linux-2.5.47/arch/i386/kernel/cpu/mcheck/non-fatal.c Wed Nov 13 13:24:45 2002
@@ -49,7 +49,6 @@
static void do_mce_timer(void *data)
{
- mce_checkregs (NULL);
smp_call_function (mce_checkregs, NULL, 1, 1);
}
@@ -57,11 +56,10 @@
static void mce_timerfunc (unsigned long data)
{
+ mce_checkregs (NULL);
#ifdef CONFIG_SMP
if (num_online_cpus() > 1)
schedule_work (&mce_work);
-#else
- mce_checkregs (NULL);
#endif
mce_timer.expires = jiffies + MCE_RATE;
add_timer (&mce_timer);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] 2.5.47 Minor bug in non-fatal machine check
2002-11-15 18:56 [PATCH] 2.5.47 Minor bug in non-fatal machine check Pallipadi, Venkatesh
@ 2002-11-18 17:39 ` Dave Jones
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jones @ 2002-11-18 17:39 UTC (permalink / raw)
To: Pallipadi, Venkatesh; +Cc: linux-kernel, torvalds
On Fri, Nov 15, 2002 at 10:56:20AM -0800, Pallipadi, Venkatesh wrote:
>
> A minor bug in nonfatal mcheck code. Non fatal machine check won't
> find any MCE faults in CONFIG_SMP and num_online_cpus==1 case, as
> mce_checkregs() will not be called at all. Attached patch should fix
> this.
Patch looks good to me..
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-11-18 17:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-11-15 18:56 [PATCH] 2.5.47 Minor bug in non-fatal machine check Pallipadi, Venkatesh
2002-11-18 17:39 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox