From: Pete Zaitcev <zaitcev@redhat.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] interrupt.h needs <asm/system.h>
Date: Mon, 18 Nov 2002 14:01:58 -0500 [thread overview]
Message-ID: <200211181901.gAIJ1wn10285@devserv.devel.redhat.com> (raw)
In-Reply-To: <mailman.1037641141.13330.linux-kernel2news@redhat.com>
><asm/system.h> is needed for smp_mb(). Apparently this definition is pulled in
> some other way on ia32.
>
> --- linux-2.5.48/include/linux/interrupt.h Mon Nov 18 10:04:00 2002
> +++ linux-m68k-2.5.48/include/linux/interrupt.h Mon Nov 18 15:35:14 2002
> @@ -8,6 +8,7 @@
> #include <asm/hardirq.h>
> #include <asm/ptrace.h>
> #include <asm/softirq.h>
> +#include <asm/system.h>
>
> struct irqaction {
> void (*handler)(int, void *, struct pt_regs *);
Geert's patch looks correct to me.
By the way, I am curious, why do we never comment why a header
was included, like so: "#include <asm/system.h> /* smp_mb */"?
I suspect people are afraid that the comments get stale.
-- Pete
next parent reply other threads:[~2002-11-18 18:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1037641141.13330.linux-kernel2news@redhat.com>
2002-11-18 19:01 ` Pete Zaitcev [this message]
2002-11-18 17:32 [PATCH] interrupt.h needs <asm/system.h> Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200211181901.gAIJ1wn10285@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox