public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.5 patch] fix compile error in usb-serial.c
@ 2002-11-18 14:39 Adrian Bunk
  2002-11-18 21:35 ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2002-11-18 14:39 UTC (permalink / raw)
  To: Rusty Russell, greg; +Cc: linux-kernel

drivers/usb/serial/usb-serial.c in 2.5.48 fails to compile with the
following error:

<--  snip  -->

...
  gcc -Wp,-MD,drivers/usb/serial/.usb-serial.o.d -D__KERNEL__ -Iinclude
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=k6
-Iarch/i386/mach-generic -nostdinc -iwithprefix include    -DKBUILD_BASENAME=usb_serial
-DKBUILD_MODNAME=usbserial   -c -o drivers/usb/serial/usb-serial.o
drivers/usb/serial/usb-serial.c
drivers/usb/serial/usb-serial.c: In function `serial_read_proc':
drivers/usb/serial/usb-serial.c:842: dereferencing pointer to incompletetype
make[3]: *** [drivers/usb/serial/usb-serial.o] Error 1

<--  snip  -->


Is the following patch correct?


--- linux-2.5.48/drivers/usb/serial/usb-serial.c.old	2002-11-18 15:16:57.000000000 +0100
+++ linux-2.5.48/drivers/usb/serial/usb-serial.c	2002-11-18 15:24:39.000000000 +0100
@@ -839,7 +839,7 @@
 
 		length += sprintf (page+length, "%d:", i);
 		if (serial->type->owner)
-			length += sprintf (page+length, " module:%s", serial->type->owner->name);
+			length += sprintf (page+length, " module:%s", module_name(serial->type->owner));
 		length += sprintf (page+length, " name:\"%s\"", serial->type->name);
 		length += sprintf (page+length, " vendor:%04x product:%04x", serial->vendor, serial->product);
 		length += sprintf (page+length, " num_ports:%d", serial->num_ports);




cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2002-11-19  2:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-11-18 14:39 [2.5 patch] fix compile error in usb-serial.c Adrian Bunk
2002-11-18 21:35 ` Greg KH
2002-11-18 22:20   ` Adrian Bunk
2002-11-18 23:26   ` Rusty Russell
2002-11-19  2:22     ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox