From: Russell King <rmk@arm.linux.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] More missing includes [1/4]
Date: Mon, 18 Nov 2002 23:17:45 +0000 [thread overview]
Message-ID: <20021118231745.D21571@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.GSO.4.21.0211182314490.16079-100000@vervain.sonytel.be>; from geert@linux-m68k.org on Mon, Nov 18, 2002 at 11:16:04PM +0100
On Mon, Nov 18, 2002 at 11:16:04PM +0100, Geert Uytterhoeven wrote:
>
> Add missing #include <linux/init.h>
>
> --- linux-2.5.48/drivers/scsi/scsi.h Mon Nov 18 10:03:40 2002
> +++ linux-m68k-2.5.48/drivers/scsi/scsi.h Mon Nov 18 14:18:21 2002
> @@ -18,6 +18,7 @@
> #include <linux/config.h> /* for CONFIG_SCSI_LOGGING */
> #include <linux/devfs_fs_kernel.h>
> #include <linux/proc_fs.h>
> +#include <linux/init.h>
>
> /*
> * Some of the public constants are being moved to this file.
>
The more obvious solution is to remove the __initdata from the
declaration on line 545. Such usage of __initdata (and __init)
serves no purpose.
--- orig/drivers/scsi/scsi.h Mon Nov 18 09:52:15 2002
+++ linux/drivers/scsi/scsi.h Mon Nov 18 15:25:42 2002
@@ -542,7 +542,7 @@
unsigned flags;
};
-extern struct dev_info scsi_static_device_list[] __initdata;
+extern struct dev_info scsi_static_device_list[];
/*
* scsi_dev_info_list: structure to hold black/white listed devices.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-11-18 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-18 22:16 [PATCH] More missing includes [1/4] Geert Uytterhoeven
2002-11-18 23:17 ` Russell King [this message]
2002-11-19 0:19 ` Richard Henderson
2002-11-19 0:23 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021118231745.D21571@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox