From: Dave Jones <davej@codemonkey.org.uk>
To: Bob Miller <rem@osdl.org>
Cc: trivial@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [TRIVIAL PATCH 2.5.48] Fixed ifdefs for a label in ncpfs/sock.c
Date: Tue, 19 Nov 2002 19:02:17 +0000 [thread overview]
Message-ID: <20021119190217.GA8317@suse.de> (raw)
In-Reply-To: <20021119185236.GI1986@doc.pdx.osdl.net>
On Tue, Nov 19, 2002 at 10:52:36AM -0800, Bob Miller wrote:
> diff -Nru a/fs/ncpfs/sock.c b/fs/ncpfs/sock.c
> --- a/fs/ncpfs/sock.c Tue Nov 19 10:31:17 2002
> +++ b/fs/ncpfs/sock.c Tue Nov 19 10:31:17 2002
> @@ -587,7 +587,9 @@
> }
> #endif
> type = ntohs(server->rcv.buf.type);
> +#ifdef CONFIG_NCPFS_PACKET_SIGNING
> cont:;
> +#endif
> if (type != NCP_REPLY) {
> if (datalen - 8 <= sizeof(server->unexpected_packet.data)) {
Eww, personally I think the fix is worse than the warning.
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2002-11-19 18:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-19 18:52 [TRIVIAL PATCH 2.5.48] Fixed ifdefs for a label in ncpfs/sock.c Bob Miller
2002-11-19 19:02 ` Dave Jones [this message]
2002-11-19 20:58 ` Bob Miller
2002-11-19 21:50 ` Petr Vandrovec
2002-11-19 23:13 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021119190217.GA8317@suse.de \
--to=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rem@osdl.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox