public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andries Brouwer <aebr@win.tue.nl>
To: Alexander Viro <viro@math.psu.edu>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Doug Ledford <dledford@redhat.com>,
	Linux Scsi Mailing List <linux-scsi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@transmeta.com>
Subject: Re: Why /dev/sdc1 doesn't show up...
Date: Tue, 19 Nov 2002 23:33:56 +0100	[thread overview]
Message-ID: <20021119223356.GA2525@win.tue.nl> (raw)
In-Reply-To: <Pine.GSO.4.21.0211190116420.27757-100000@steklov.math.psu.edu>

On Tue, Nov 19, 2002 at 02:12:54AM -0500, Alexander Viro wrote:

> BTW, remember the flamef^Warguments about turning kdev_t into a pointer
> and thus avoiding digging through piles and piles of cr^Hode?  Didn't
> fly for exactly the same reasons - there's no way to do it magically
> for entire kernel without breaking tons of code and/or creating an
> impossible-to-debug mess...

You never convinced me. Maybe we ever meet and can talk..

In the meantime:
Yesterday or so I built versions of 2.5.48 with 32-bit and 64-bit dev_t.

The code is full of conversions dev_t -> int -> dev_t -> int.
Ugly. I gave the mknod method in struct inode_operations type
	int (*mknod) (struct inode *,struct dentry *,int,dev_t);
thus avoiding much conversion.
Do you have objections?

Andries

# mount /dev/hde6 /fbsd6 -t ufs -o ufstype=44bsd,ro
# ./ls -l /fbsd6/dev/da2s[34]
brw-r-----   1     root      disk    4, 0x040012 Oct 31 21:06 /fbsd6/dev/da2s3
brw-r-----   1     root      disk    4, 0x050012 Oct 31 21:06 /fbsd6/dev/da2s4
#

  parent reply	other threads:[~2002-11-19 22:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-19  5:52 Why /dev/sdc1 doesn't show up Rusty Russell
2002-11-19  7:12 ` Alexander Viro
2002-11-19 21:29   ` Rusty Russell
2002-11-19 22:33   ` Andries Brouwer [this message]
2002-11-19 16:06 ` Doug Ledford
2002-11-19 17:55 ` Jeff Garzik
2002-11-19 21:42   ` Rusty Russell
2002-11-20 23:41   ` john slee
  -- strict thread matches above, loose matches on Subject: below --
2002-11-17 19:52 Doug Ledford
2002-11-17 20:01 ` Alexander Viro
2002-11-17 20:12   ` Doug Ledford
2002-11-17 20:16   ` Alexander Viro
2002-11-17 23:20 ` Andries Brouwer
2002-11-17 23:45   ` Doug Ledford
2002-11-18  8:52 ` Rusty Russell
2002-11-18  9:51   ` Alexander Viro
2002-11-18 23:49     ` Rusty Russell
2002-11-19  0:08       ` Linus Torvalds
2002-11-19 20:54         ` Rusty Russell
2002-11-20 15:45           ` Linus Torvalds
2002-11-24 22:30             ` Rusty Russell
2002-11-19  0:09       ` Doug Ledford
2002-11-19 20:58         ` Rusty Russell
2002-11-19  0:32       ` Alan Cox
2002-11-18 10:02   ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021119223356.GA2525@win.tue.nl \
    --to=aebr@win.tue.nl \
    --cc=dledford@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@transmeta.com \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox