The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Larry McVoy <lm@bitmover.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	LKML <linux-kernel@vger.kernel.org>,
	anton@samba.org, "David S. Miller" <davem@redhat.com>,
	ak@muc.de
Subject: Re: [PATCH] Beginnings of conpat 32 code cleanups
Date: Fri, 22 Nov 2002 11:54:54 -0800	[thread overview]
Message-ID: <20021122115454.A481@work.bitmover.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0211221141070.1440-100000@penguin.transmeta.com>; from torvalds@transmeta.com on Fri, Nov 22, 2002 at 11:47:27AM -0800

> Make your compat stuff use u32/s32/u64 directly, instead of making up ugly 
> new types that make no sense.

IMHO, the thing that the early Unix systems did wrong was to not have 
u8, u16, u32, etc as basic ctypes in sys/types.h.  And C should have 
had a way to fake it if they weren't native.

Anyone who has ported a networking stack or worked on driver knows exactly
what I'm talking about.

And while I'm whining, 

	assert(strlen(any typedef) < 8));

I like my stack variable declarations to line up.  I despise some_long_name_t
typedefs with a passion.
-- 
---
Larry McVoy            	 lm at bitmover.com           http://www.bitmover.com/lm 

  reply	other threads:[~2002-11-22 19:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-22  5:23 [PATCH] Beginnings of conpat 32 code cleanups Stephen Rothwell
2002-11-22 19:47 ` Linus Torvalds
2002-11-22 19:54   ` Larry McVoy [this message]
2002-11-22 20:13     ` Cort Dougan
2002-11-22 20:38       ` H. Peter Anvin
2002-11-23  0:28   ` Stephen Rothwell
2002-11-25 19:48     ` Linus Torvalds
2002-11-23  5:16   ` Anton Blanchard
2002-11-25 20:00     ` Linus Torvalds
2002-11-26 13:53 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021122115454.A481@work.bitmover.com \
    --to=lm@bitmover.com \
    --cc=ak@muc.de \
    --cc=anton@samba.org \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox