From: Jens Axboe <axboe@suse.de>
To: Andy Chou <acc@CS.Stanford.EDU>
Cc: linux-kernel@vger.kernel.org, mc@cs.stanford.edu
Subject: Re: [CHECKER] 5 additional buffer overruns in 2.5.48
Date: Sun, 24 Nov 2002 13:37:37 +0100 [thread overview]
Message-ID: <20021124123737.GY11884@suse.de> (raw)
In-Reply-To: <20021124063756.GA14294@Xenon.stanford.edu>
On Sat, Nov 23 2002, Andy Chou wrote:
> ---------------------------------------------------------
> [BUG] [GEM] base starts at offset 4 of buf
> /u1/acc/linux/2.5.48/drivers/cdrom/cdrom.c:1170:dvd_read_physical:
> ERROR:BUFFER:1170:1170:Array bounds error: base[16] indexed with [16]
> layer->track_density = base[3] & 0xf;
> layer->linear_density = base[3] >> 4;
> layer->start_sector = base[5] << 16 | base[6] << 8 | base[7];
> layer->end_sector = base[9] << 16 | base[10] << 8 | base[11];
> layer->end_sector_l0 = base[13] << 16 | base[14] << 8 | base[15];
>
> Error --->
> layer->bca = base[16] >> 7;
>
> return 0;
Ah good catch. The buf[20] is simply too small, it must be 21 (or
probably just 22 to make it even, the size is 21 bytes for header and
data)
--
Jens Axboe
next prev parent reply other threads:[~2002-11-24 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-24 6:37 [CHECKER] 5 additional buffer overruns in 2.5.48 Andy Chou
2002-11-24 12:37 ` Jens Axboe [this message]
2002-11-30 23:41 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021124123737.GY11884@suse.de \
--to=axboe@suse.de \
--cc=acc@CS.Stanford.EDU \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox