public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Waechtler <pwaechtler@mac.com>
To: Michal Wronski <wrona@mat.uni.torun.pl>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] unified SysV and POSIX mqueues - complete rewrite
Date: Tue, 26 Nov 2002 12:16:52 +0100	[thread overview]
Message-ID: <200211261216.52359.pwaechtler@mac.com> (raw)
In-Reply-To: <Pine.GSO.4.40.0211261010020.24735-100000@Juliusz>

Am Dienstag, 26. November 2002 10:12 schrieb Michal Wronski:
> I have a few remarks/questions:
>
> 1. I can't find unregister_filesystem in your patch

I removed the unused code. I can't have a module
with it's own syscalls - posixmsg can't be a module for that reason.

> 2. You have different MQ_PRIO_MAX in library and patch.

Umh, the value is really arbitrary. Could be something like MAX_INT -1

> 3. Does mq_unlink work in a proper way?

I do think so. Did you test it and found a bug?
The vfs keeps track of a reference count. Only when the usage count
of the inode drops to zero, the mqueue_release is called. 
I tested it and it worked.
Even when there is a process in mq_receive() waiting, only the name
is removed as you expect it with unix filesystem semantics. SuSv3
explicitly allows that:

"Calls to mq_open() to recreate the message queue may fail until the message 
queue is actually removed. However, the mq_unlink() call need not block until 
all references have been closed; it may return immediately."



  reply	other threads:[~2002-11-26 11:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <EDC461A30AC4D511ADE10002A5072CAD04C70992@orsmsx119.jf.intel.com>
2002-11-13 15:10 ` [PATCH] unified SysV and POSIX mqueues - complete rewrite Michal Wronski
2002-11-13 22:25   ` Peter Waechtler
2002-11-19 11:28     ` Krzysztof Benedyczak
2002-11-19 16:42       ` Peter Waechtler
2002-11-24 11:55   ` Michal Wronski
2002-11-26  9:12     ` Michal Wronski
2002-11-26 11:16       ` Peter Waechtler [this message]
2002-11-24 23:05 Peter Waechtler
     [not found] ` <3DE15F9E.A585E26F@digeo.com>
2002-11-25  1:02   ` Peter Waechtler
  -- strict thread matches above, loose matches on Subject: below --
2002-11-19 19:12 Perez-Gonzalez, Inaky
2002-11-10 23:44 Peter Waechtler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200211261216.52359.pwaechtler@mac.com \
    --to=pwaechtler@mac.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wrona@mat.uni.torun.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox