public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] named struct initialiser updates
       [not found] <200211260414.gAQ4EaJ26436@hera.kernel.org>
@ 2002-11-29  9:45 ` Geert Uytterhoeven
  2002-11-29 11:49   ` Dave Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2002-11-29  9:45 UTC (permalink / raw)
  To: Linux Kernel Mailing List

On Tue, 26 Nov 2002, Linux Kernel Mailing List wrote:
> ChangeSet 1.842.43.47, 2002/11/25 18:40:22-08:00, davej@codemonkey.org.uk
> 
> 	[PATCH] named struct initialiser updates


> diff -Nru a/drivers/video/fbcon.c b/drivers/video/fbcon.c
> --- a/drivers/video/fbcon.c	Mon Nov 25 20:14:39 2002
> +++ b/drivers/video/fbcon.c	Mon Nov 25 20:14:39 2002
> @@ -230,8 +230,9 @@
>  
>  static void cursor_timer_handler(unsigned long dev_addr);
>  
> -static struct timer_list cursor_timer =
> -		TIMER_INITIALIZER(cursor_timer_handler, 0, 0);
> +static struct timer_list cursor_timer = {
> +    function: cursor_timer_handler
> +};
>  
>  static void cursor_timer_handler(unsigned long dev_addr)
>  {

Doesn't this part reverse the timer initializer fix?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] named struct initialiser updates
  2002-11-29  9:45 ` [PATCH] named struct initialiser updates Geert Uytterhoeven
@ 2002-11-29 11:49   ` Dave Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Dave Jones @ 2002-11-29 11:49 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Linux Kernel Mailing List

On Fri, Nov 29, 2002 at 10:45:24AM +0100, Geert Uytterhoeven wrote:

 > > diff -Nru a/drivers/video/fbcon.c b/drivers/video/fbcon.c
 > > --- a/drivers/video/fbcon.c	Mon Nov 25 20:14:39 2002
 > > +++ b/drivers/video/fbcon.c	Mon Nov 25 20:14:39 2002
 > > @@ -230,8 +230,9 @@
 > >  
 > >  static void cursor_timer_handler(unsigned long dev_addr);
 > >  
 > > -static struct timer_list cursor_timer =
 > > -		TIMER_INITIALIZER(cursor_timer_handler, 0, 0);
 > > +static struct timer_list cursor_timer = {
 > > +    function: cursor_timer_handler
 > > +};
 > Doesn't this part reverse the timer initializer fix?

Looks like it. I'll take a look later.

		Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-11-29 11:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <200211260414.gAQ4EaJ26436@hera.kernel.org>
2002-11-29  9:45 ` [PATCH] named struct initialiser updates Geert Uytterhoeven
2002-11-29 11:49   ` Dave Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox