From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 29 Nov 2002 06:44:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 29 Nov 2002 06:44:33 -0500 Received: from noodles.codemonkey.org.uk ([213.152.47.19]:37764 "EHLO noodles.internal") by vger.kernel.org with ESMTP id ; Fri, 29 Nov 2002 06:44:32 -0500 Date: Fri, 29 Nov 2002 11:49:36 +0000 From: Dave Jones To: Geert Uytterhoeven Cc: Linux Kernel Mailing List Subject: Re: [PATCH] named struct initialiser updates Message-ID: <20021129114935.GA20166@suse.de> Mail-Followup-To: Dave Jones , Geert Uytterhoeven , Linux Kernel Mailing List References: <200211260414.gAQ4EaJ26436@hera.kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 29, 2002 at 10:45:24AM +0100, Geert Uytterhoeven wrote: > > diff -Nru a/drivers/video/fbcon.c b/drivers/video/fbcon.c > > --- a/drivers/video/fbcon.c Mon Nov 25 20:14:39 2002 > > +++ b/drivers/video/fbcon.c Mon Nov 25 20:14:39 2002 > > @@ -230,8 +230,9 @@ > > > > static void cursor_timer_handler(unsigned long dev_addr); > > > > -static struct timer_list cursor_timer = > > - TIMER_INITIALIZER(cursor_timer_handler, 0, 0); > > +static struct timer_list cursor_timer = { > > + function: cursor_timer_handler > > +}; > Doesn't this part reverse the timer initializer fix? Looks like it. I'll take a look later. Dave -- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs