Re: scx200_gpio.c doesn't compile in 2.5.50

[Arnaldo Carvalho de Melo <acme@conectiva.com.br>]

Em Sun, Dec 01, 2002 at 12:35:29AM +0100, Christer Weinigel escreveu:
> Arnaldo Carvalho de Melo <acme@conectiva.com.br> writes:
> 
> > Em Sat, Nov 30, 2002 at 11:49:39PM +0100, Christer Weinigel escreveu:
> > > Adrian Bunk <bunk@fs.tum.de> writes:
> > > 
> > > > Compilation of drivers/char/scx200_gpio.c fails in 2.5.50 with the error
> > > > messages below.
> > > 
> > > Thanks for the report.  Patch follows.
> > > 
> > > Alan, do you want small fixes like these or should I send them to
> > > someone else?
> > 
> > 	I have this one on my misc-2.5 bk tree that I'll be pushing to Linus
> > RSN. It is also required that we include kdev_t.h, as this driver uses the
> > minor() macro.
> 
> Thanks.  Is there any list of what include files one must use to use
> for example the minor macro?  I looked at fs.h and saw that it
> included kdev_t.h so I skipped including that file myself.  But
> relying on things like that is what bit me to begin with.

Well, I rather encourage to include the files that have the definition of 
symbols in the .c file, that way if, taking your example: if fs.h for some
reason removed the include kdev_t.h, scx200_gpio.c would stop compiling.

- Arnaldo