public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tomas Szepe <szepe@pinerecords.com>
To: Alan Cox <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.20-ac1
Date: Sun, 1 Dec 2002 10:32:34 +0100	[thread overview]
Message-ID: <20021201093234.GC22272@louise.pinerecords.com> (raw)
In-Reply-To: <200212010201.gB1210d11940@devserv.devel.redhat.com>

> > >  	drive->using_dma = 1;
> > >  	ide_toggle_bounce(drive, 1);
> > > +	printk(KERN_INFO "%s: DMA enabled\n", drive->name);
> > >  	return HWIF(drive)->ide_dma_host_on(drive);
> > >  }
> > 
> > with the above applied:
> 
> Better I think that via drivers turn DMA off -quietly-

This isn't just via but possibly all drivers
that call ide-iops.c::ide_config_drive_speed() --

arm/icside.c pci/aec62xx.c pci/alim15x3.c pci/amd74xx.c pci/cmd64x.c
pci/cs5530.c pci/hpt34x.c pci/hpt366.c pci/it8172.c pci/nvidia.c
pci/pdc202xx_new.c pci/pdc202xx_old.c pci/piix.c pci/sc1200.c
pci/serverworks.c pci/siimage.c pci/sis5513.c pci/sl82c105.c
pci/slc90e66.c pci/via82cxxx.c

The following bit kills the noise:

diff -urN linux-2.4.20-ac1/drivers/ide/ide-iops.c linux-2.4.20-ac1.x/drivers/ide/ide-iops.c
--- linux-2.4.20-ac1/drivers/ide/ide-iops.c	2002-12-01 10:23:29 +0100
+++ linux-2.4.20-ac1.x/drivers/ide/ide-iops.c	2002-12-01 10:16:00 +0100
@@ -891,7 +891,7 @@
 	if (speed >= XFER_SW_DMA_0)
 		hwif->ide_dma_host_on(drive);
 	else
-		hwif->ide_dma_off(drive);
+		hwif->ide_dma_off_quietly(drive);
 #endif /* (CONFIG_BLK_DEV_IDEDMA) && !(CONFIG_DMA_NONPCI) */
 
 	switch(speed) {

--
Tomas Szepe <szepe@pinerecords.com>

  reply	other threads:[~2002-12-01  9:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-29 23:24 Linux 2.4.20-ac1 Alan Cox
2002-11-30  0:47 ` Jarno Paananen
2002-12-01  0:59   ` Dave Jones
2002-11-30  7:00 ` Joshua Kwan
2002-11-30 11:40 ` Steffen Moser
2002-11-30 13:45   ` Alan Cox
2002-11-30 16:40     ` Tomas Szepe
2002-11-30 18:34       ` Tomas Szepe
2002-12-01  2:01         ` Alan Cox
2002-12-01  9:32           ` Tomas Szepe [this message]
2002-12-03 20:06 ` Gary White
2002-12-03 20:21   ` Philippe Gramoullé
  -- strict thread matches above, loose matches on Subject: below --
2002-11-30 12:12 Jens-Christian Skibakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021201093234.GC22272@louise.pinerecords.com \
    --to=szepe@pinerecords.com \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox