From: Hiroshi Miura <miura@da-cha.org>
To: alan@redhat.com, sfr@canb.auug.org.au, linux-kernel@vger.kernel.org
Cc: miura@da-cha.org, pavel@ucw.cz, "Heller,
Christian (Research)" <heller@crd.ge.com>
Subject: Re: [PATCH] 2.5.50 apm.c better printk messages about workaround.
Date: Wed, 4 Dec 2002 14:31:49 +0900 (JST) [thread overview]
Message-ID: <20021204053149.DBEFC1178B8@triton2> (raw)
In-Reply-To: Hiroshi Miura's message of "Tue, 3 Dec 02 14:28:19 JST"
Sorry,
I mistake in my patch.
I add '\n' now.
> I post patch about work around for a broken bios.
> Pavel comments and i think it is reasonable and better.
>
> this patch fix printk message in 2.5.50.
--- linux-2.5.50/arch/i386/kernel/apm.c 2002-12-03 07:59:30.000000000 +0900
+++ linux-2.5.50-geode/arch/i386/kernel/apm.c 2002-12-03 14:04:11.000000000 +0900
@@ -2054,12 +2054,14 @@
_set_limit((char *)&cpu_gdt_table[i][APM_DS >> 3],
(apm_info.bios.dseg_len - 1) & 0xffff);
/* workaround for broken BIOSes */
- if (apm_info.bios.cseg_len <= apm_info.bios.offset)
+ if (apm_info.bios.cseg_len <= apm_info.bios.offset) {
_set_limit((char *)&cpu_gdt_table[i][APM_CS >> 3], 64 * 1024 -1);
- if (apm_info.bios.dseg_len <= 0x40) { /* 0x40 * 4kB == 64kB */
+ printk(KERN_WARNING "apm: broken bios -- code segment too short, assuming 64k.\n");
+ }
+ if (apm_info.bios.dseg_len <= 0x40) { /* 0x40 * 4kB == 64kB */
/* for the BIOS that assumes granularity = 1 */
cpu_gdt_table[i][APM_DS >> 3].b |= 0x800000;
- printk(KERN_NOTICE "apm: we set the granularity of dseg.\n");
+ printk(KERN_WARNING "apm: broken bios -- assuming granularity 1 on dseg.\n");
}
}
#endif
--
Hiroshi Miura --- http://www.da-cha.org/
NTTDATA Corp. Marketing & Business Strategy Planning Dept. --- miurahr@nttdata.co.jp
Key fingerprint = 9117 9407 5684 FBF1 4063 15B4 401D D077 04AB 8617
-- My hacking life is happy as the day is long
next reply other threads:[~2002-12-05 4:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-04 5:31 Hiroshi Miura [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-12-03 5:28 [PATCH] 2.5.50 apm.c better printk messages about workaround Hiroshi Miura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021204053149.DBEFC1178B8@triton2 \
--to=miura@da-cha.org \
--cc=alan@redhat.com \
--cc=heller@crd.ge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox