Re: [warnings] [2/8] fix uninitialized quot in drivers/serial/core.c

Russell King
2002-12-05T11:12:26Z

On Thu, Dec 05, 2002 at 02:52:59AM -0800, wli@holomorphy.com wrote:
> Give quot a default value so it's initialized. rmk, this is yours
> to ack.

Why can't we get this obvious compiler bug fixed? I'd rather have
the compiler bug fixed rather than trying to work around the bogus
warning.

It's obvious that the loop:

for (try = 0; try < 3; try++)

is going to be executed at least once, which will initialise quot.

As for the second hunk, its correct in so far as it'll catch the case
where we can't even do 9600 baud. However, I think we should just
bound the lowest baud rate such that we can always do 9600 baud (and
therefore this function will never return zero.)

--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux