From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 5 Dec 2002 13:06:02 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 5 Dec 2002 13:06:02 -0500 Received: from 12-231-249-244.client.attbi.com ([12.231.249.244]:28176 "HELO kroah.com") by vger.kernel.org with SMTP id ; Thu, 5 Dec 2002 13:06:02 -0500 Date: Thu, 5 Dec 2002 10:13:24 -0800 From: Greg KH To: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-security-module@wirex.com Subject: Re: [PATCH] LSM changes for 2.5.50 Message-ID: <20021205181324.GA3867@kroah.com> References: <20021205163152.GA2865@kroah.com> <20021205163234.GB2865@kroah.com> <20021205163300.GC2865@kroah.com> <20021205163339.GD2865@kroah.com> <20021205163406.GE2865@kroah.com> <20021205163541.GF2865@kroah.com> <20021205170002.A30875@infradead.org> <20021205180357.GB3712@kroah.com> <20021205180646.A707@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021205180646.A707@infradead.org> User-Agent: Mutt/1.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 05, 2002 at 06:06:47PM +0000, Christoph Hellwig wrote: > On Thu, Dec 05, 2002 at 10:03:58AM -0800, Greg KH wrote: > > On Thu, Dec 05, 2002 at 05:00:02PM +0000, Christoph Hellwig wrote: > > > On Thu, Dec 05, 2002 at 08:35:42AM -0800, Greg KH wrote: > > > > ChangeSet 1.797.142.4, 2002/12/04 16:56:51-06:00, greg@kroah.com > > > > > > > > LSM: add the example rootplug module > > > > > > I don't think that's the kind of module that should be merged.. > > > > Why? We have other "example" drivers in the kernel tree. This is just > > like that. > > because it a) implements silly policy That was the point :) And I've seen sillier in "real" security products too... > and b) violates layer rules. What do you mean by this? The fact that it abuses the USB core? If so, yes I agree with you, so I should probably move the "is this USB device present" functionality into the USB core for everyone to use. Would that be better? thanks, greg k-h