linux-2.4.20 fails to build with aic7xxx

linux-2.4.20 fails to build with aic7xxx

[Ralf Hildebrandt]

We get:

...
make[3]: Entering directory /usr/src/linux-2.4.20/drivers/scsi'
/usr/bin/make -C aic7xxx
make[4]: Entering directory /usr/src/linux-2.4.20/drivers/scsi/aic7xxx'
/usr/bin/make all_targets
make[5]: Entering directory /usr/src/linux-2.4.20/drivers/scsi/aic7xxx'
/usr/bin/make -C aicasm
make[6]: Entering directory
/usr/src/linux-2.4.20/drivers/scsi/aic7xxx/aicasm'
yacc -d -b aicasm_gram aicasm_gram.y
aicasm_gram.y:921.21: parse error, unexpected ":", expecting ";" or "|"
aicasm_gram.y:936.2-5: $$ of critical_section_start' has no declared type
aicasm_gram.y:938.2-5: $$ of critical_section_start' has no declared type
make[6]: *** [aicasm_gram.h] Error 1
make[6]: Leaving directory
/usr/src/linux-2.4.20/drivers/scsi/aic7xxx/aicasm'
make[5]: *** [aicasm/aicasm] Error 2
make[5]: Leaving directory /usr/src/linux-2.4.20/drivers/scsi/aic7xxx'
make[4]: *** [first_rule] Error 2
make[4]: Leaving directory /usr/src/linux-2.4.20/drivers/scsi/aic7xxx'
make[3]: *** [_subdir_aic7xxx] Error 2
make[3]: Leaving directory /usr/src/linux-2.4.20/drivers/scsi'
make[2]: *** [_subdir_scsi] Error 2
make[2]: Leaving directory /usr/src/linux-2.4.20/drivers'
make[1]: *** [_dir_drivers] Error 2
make[1]: Leaving directory /usr/src/linux-2.4.20'
make: *** [stamp-build] Error 2

# yacc -V
bison (GNU Bison) 1.75
Written by Robert Corbett and Richard Stallman.

Copyright (C) 2002 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There
is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE.

# grep -i AIC .config
CONFIG_SCSI_AIC7XXX=y
CONFIG_AIC7XXX_CMDS_PER_DEVICE=253
CONFIG_AIC7XXX_RESET_DELAY_MS=15000
# CONFIG_AIC7XXX_PROBE_EISA_VL is not set
CONFIG_AIC7XXX_BUILD_FIRMWARE=y

-- 
Ralf Hildebrandt (Im Auftrag des Referat V a)   Ralf.Hildebrandt@charite.de
Charite Campus Mitte                            Tel.  +49 (0)30-450 570-155
Referat V a - Kommunikationsnetze -             Fax.  +49 (0)30-450 570-916

Re: linux-2.4.20 fails to build with aic7xxx

[Marc-Christian Petersen]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi Ralf,

> yacc -d -b aicasm_gram aicasm_gram.y
> aicasm_gram.y:921.21: parse error, unexpected ":", expecting ";" or "|"
> aicasm_gram.y:936.2-5: $$ of critical_section_start' has no declared type
> aicasm_gram.y:938.2-5: $$ of critical_section_start' has no declared type
> make[6]: *** [aicasm_gram.h] Error 1
the fix is imho the easiest fix anyone ever done on earth ;)

attached!

ciao, Marc


[-- Attachment #2: 175_aic7xxx-build-fix.patch --]
[-- Type: text/x-diff, Size: 306 bytes --]

--- linux-old/drivers/scsi/aic7xxx/aicasm/aicasm_gram.y	2002-09-27 23:25:52.000000000 +0200
+++ linux-wolk4/drivers/scsi/aicasm_gram.y	2002-12-06 17:28:03.000000000 +0100
@@ -917,6 +917,7 @@
 		cs->begin_addr = instruction_ptr;
 		in_critical_section = TRUE;
 	}
+;
 
 critical_section_end:
 	T_END_CS ';'

Re: linux-2.4.20 fails to build with aic7xxx

[Ralf Hildebrandt]

* Marc-Christian Petersen <m.c.p@wolk-project.de>:

> the fix is imho the easiest fix anyone ever done on earth ;)

If one knows yacc!

-- 
Ralf Hildebrandt (Im Auftrag des Referat V a)   Ralf.Hildebrandt@charite.de
Charite Campus Mitte                            Tel.  +49 (0)30-450 570-155
Referat V a - Kommunikationsnetze -             Fax.  +49 (0)30-450 570-916
llama would be a more fitting name for OpenLDAP: 
It's big, stubborn and spits in your face when you need it the most.

Re: linux-2.4.20 fails to build with aic7xxx

[Justin T. Gibbs]

> Hi Ralf,
> 
>> yacc -d -b aicasm_gram aicasm_gram.y
>> aicasm_gram.y:921.21: parse error, unexpected ":", expecting ";" or "|"
>> aicasm_gram.y:936.2-5: $$ of critical_section_start' has no declared type
>> aicasm_gram.y:938.2-5: $$ of critical_section_start' has no declared type
>> make[6]: *** [aicasm_gram.h] Error 1
> the fix is imho the easiest fix anyone ever done on earth ;)
> 
> attached!

Actually, there is another missing ';' near the first you caught.  I've
updated my local sources and will release a new driver drop for 2.4.X
today.

--
Justin

Re: linux-2.4.20 fails to build with aic7xxx

[Ralf Hildebrandt]

* Justin T. Gibbs <gibbs@scsiguy.com>:

> Actually, there is another missing ';' near the first you caught.  I've
> updated my local sources and will release a new driver drop for 2.4.X
> today.

I noticed that. We have the recent kernel running by now :)

-- 
Ralf Hildebrandt (Im Auftrag des Referat V a)   Ralf.Hildebrandt@charite.de
Charite Campus Mitte                            Tel.  +49 (0)30-450 570-155
Referat V a - Kommunikationsnetze -             Fax.  +49 (0)30-450 570-916
It is better to keep your mouth shut and be thought a fool, than to
open it and remove all doubt.