public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Antonino Daplas <adaplas@pol.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG]: agpgart for i810 chipsets broken in 2.5.51
Date: Tue, 10 Dec 2002 17:05:42 +0000	[thread overview]
Message-ID: <20021210170542.GB577@codemonkey.org.uk> (raw)
In-Reply-To: <1039539977.14251.40.camel@irongate.swansea.linux.org.uk>

On Tue, Dec 10, 2002 at 05:06:17PM +0000, Alan Cox wrote:
 > Given how fragile the AGP code can be I would much rather we had the AGP
 > continue to initialize late. If the AGP init function is something like
 > 
 > 
 > int agp_required(void)
 > {
 > 	static int agp_inited = 0;
 > 
 > 	if(!agp_inited)
 > 	{
 > 		agp_inited = 1;
 > 		agp_do_real_init();
 > 	}
 > }
 > 
 > module_init(agp_required);
 > 
 > 
 > Then the i810 fb driver can do
 > 
 > 	agp_required();
 > 
 > and force the order change only if necessary.

That works for me. It's not ideal, but it's the cleanest
solution suggested so far. I'll hack a check into
agp_init() to do this, which should allow us to close bug #20 [*]

        Dave

[*] http://bugzilla.kernel.org/show_bug.cgi?id=20


  reply	other threads:[~2002-12-10 16:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-10 12:21 [BUG]: agpgart for i810 chipsets broken in 2.5.51 Antonino Daplas
2002-12-10 13:11 ` Dave Jones
2002-12-10 16:47   ` Antonino Daplas
2002-12-10 14:03     ` Dave Jones
2002-12-10 17:34       ` Antonino Daplas
2002-12-10 19:08       ` Antonino Daplas
2002-12-10 16:23         ` Dave Jones
2002-12-10 17:06           ` Alan Cox
2002-12-10 17:05             ` Dave Jones [this message]
2002-12-10 21:00               ` Antonino Daplas
2002-12-10 18:21                 ` Dave Jones
2002-12-10 21:23                   ` Antonino Daplas
2002-12-10 19:36           ` Antonino Daplas
2002-12-10 14:48     ` Dave Jones
2002-12-10 19:07       ` Antonino Daplas
2002-12-10 16:17         ` Dave Jones
2002-12-10 19:37           ` Antonino Daplas
2002-12-10 21:01           ` Antonino Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021210170542.GB577@codemonkey.org.uk \
    --to=davej@codemonkey.org.uk \
    --cc=adaplas@pol.net \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox