From: DervishD <raul@pleyades.net>
To: "David S. Miller" <davem@redhat.com>
Cc: Linux-kernel <linux-kernel@vger.kernel.org>,
Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: Patch reversion needed too for -ac and 2.5.x
Date: Tue, 10 Dec 2002 23:25:53 +0100 [thread overview]
Message-ID: <20021210222553.GB46@DervishD> (raw)
Hi David :)
I understand why you suggested the reversion, and, unfortunately,
the MM code is plagued by bad usage of the PAGE_ALIGN macro. This
macro fails for aligning a *size* when this size is larger than
SIZE_MAX-PAGE_SIZE. Too bad.
Anyway, if you want the patch reverted, tell too to Alan Cox and
Linus, because their branches have this patch applied and well,
although I think that the patch does no harm, really the solution is
to write a new macro for aligning sizes, not addresses, and this is a
very big change that surely won't be accepted.
Tell Alan and Linus for having the patch reverted for their trees
if you feel like that. Do you think that a new macro will solve the
corner case without doing nothing on 'big TASK_SIZE' archs? If you
think so, I can provide with a macro and have it checked by you :)
Don't take it bad, Dave ;) It's just that althoug my solution was
not perfect, certainly is best than what we have now ;)
Raúl
reply other threads:[~2002-12-10 22:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021210222553.GB46@DervishD \
--to=raul@pleyades.net \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox