Re: 2.5.51 don't compil with dvb

[Rusty Russell <rusty@rustcorp.com.au>]

On 10 Dec 2002 16:05:15 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> On Tue, 2002-12-10 at 15:07, Gregoire Favre wrote:
> > drivers/built-in.o(.text+0x38655): In function `try_attach_device':
> > : undefined reference to `MOD_CAN_QUERY'
> > make: *** [vmlinux] Error 1
> > 
> 
> Modules are still very broken in 2.5.51, its best to compile a system
> which doesn't use modules or stay at an older kernel

That may be true, but in this case, it's the only occurrance of MOD_CAN_QUERY
outside the archs which haven't been updated to the new module loader yet,
and it's a very odd thing to do.

I assume the author meant this:

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.5.51/drivers/media/dvb/dvb-core/dvb_i2c.c working-2.5.51-dvb/drivers/media/dvb/dvb-core/dvb_i2c.c
--- linux-2.5.51/drivers/media/dvb/dvb-core/dvb_i2c.c	2002-11-28 10:20:07.000000000 +1100
+++ working-2.5.51-dvb/drivers/media/dvb/dvb-core/dvb_i2c.c	2002-12-11 10:53:09.000000000 +1100
@@ -64,10 +64,8 @@ static
 void try_attach_device (struct dvb_i2c_bus *i2c, struct dvb_i2c_device *dev)
 {
 	if (dev->owner) {
-		if (!MOD_CAN_QUERY(dev->owner))
+		if (!try_inc_mod_count(dev->owner))
 			return;
-
-		__MOD_INC_USE_COUNT(dev->owner);
 	}
 
 	if (dev->attach (i2c) == 0) {


-- 
   there are those who do and those who hang on and you don't see too
   many doers quoting their contemporaries.  -- Larry McVoy