[PATCH] mmap.c - do_mmap_pgoff() small correction

[PATCH] mmap.c - do_mmap_pgoff() small correction

[DervishD]

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

    Hi Linus :)

    This is a correction for a patch I sent you that you included in
the 2.5.x tree. The patch I sent you fixed a corner case for the
mmap() syscall, where the requested size was too big (namely, bigger
than SIZE_MAX-PAGE_SIZE). Unfortunately, the patch did a wrong
assumption that is not true in some archs where TASK_SIZE is the full
address space available, as sparc64. So, the patch didn't fix
anything on those archs :((

    David S. Miller <davem@redhat.com> pointed this and made this new
patch that fixes the spot. Now it should work in all archs.

    If you have any doubt, just tell.

    Raúl

[-- Attachment #2: mmap.c.diff --]
[-- Type: text/plain, Size: 472 bytes --]

--- linux/mm/mmap.c.orig	2002-12-11 14:27:04.000000000 +0100
+++ linux/mm/mmap.c	2002-12-11 14:28:09.000000000 +0100
@@ -421,14 +421,14 @@
 	if (file && (!file->f_op || !file->f_op->mmap))
 		return -ENODEV;
 
-	if (!len)
+	if (len == 0)
 		return addr;
 
-	if (len > TASK_SIZE)
-		return -EINVAL;
-
 	len = PAGE_ALIGN(len);
 
+	if (len > TASK_SIZE || len == 0)
+		return -EINVAL;
+
 	/* offset overflow? */
 	if ((pgoff + (len >> PAGE_SHIFT)) < pgoff)
 		return -EINVAL;

[RESEND][PATCH] mmap.c - do_mmap_pgoff() small correction

[DervishD]

     Hi Linus :)
 
     This is a correction for a patch I sent you that you included in
 the 2.5.x tree. The patch I sent you fixed a corner case for the
 mmap() syscall, where the requested size was too big (namely, bigger
 than SIZE_MAX-PAGE_SIZE). Unfortunately, the patch did a wrong
 assumption that is not true in some archs where TASK_SIZE is the full
 address space available, as sparc64. So, the patch didn't fix
 anything on those archs :((
 
     David S. Miller <davem@redhat.com> pointed this and made this new
 patch that fixes the spot. Now it should work in all archs.
 
     If you have any doubt, just tell. The patch is against 2.5.60,
please apply or the corner case won't be fixed on sparc64. Thanks a
lot :)
 
     Raúl