Re: 2.5.51 ide module problem (fwd)

[Rusty Russell <rusty@rustcorp.com.au>]

In message <Pine.LNX.4.50.0212121419410.15261-100000@boston.corp.fedex.com> you
 write:
> 
> Rusty,
> 
> Any chance that module-init-tools-0.9.3 can be modified to stop looping
> when it detected it has repeated scanning the same module again?

I didn't see this report before, so it's the first I've heard of it.

> > 	I think the new depmod recurses infinitely when it encounters
> > circular dependencies.  It eventually segfaults and leaves a huge
> > modules.dep file from the infinite loop.  If you look at the final
> > huge line in that file, you can see where the loop occurred.
> >
> > 	depmod has no need to do any recursion, since it only needs
> > to determine the immediate dependencies of each module.  However,
> > noticing such loops and printing them out would be a handy feature.

Actually, depmod should print out every dependency, so that modprobe
doesn't have to do the recursion check.

But yes, circular dependencies will screw it.

> >depmod will ecounter "Segmentation fault" if the ide.ko and ide-io.ps
> >modules are in /lib/modules/2.5.51/kernel

I'll test, and release a fix.

Thanks for the (indirect) bug report!
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.