From: "Vamsi Krishna S ." <vamsi@in.ibm.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
John Levon <levon@movementarian.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Notifier for significant events on i386
Date: Thu, 12 Dec 2002 13:04:06 +0530 [thread overview]
Message-ID: <20021212130406.A20253@in.ibm.com> (raw)
In-Reply-To: <1039652384.1649.17.camel@dell_ss3.pdx.osdl.net>; from shemminger@osdl.org on Thu, Dec 12, 2002 at 12:25:47AM +0000
On Thu, Dec 12, 2002 at 12:25:47AM +0000, Stephen Hemminger wrote:
>
> This patch changes notifier to use RCU. No interface change, just a little
> more memory in each notifier_block. Also some formatting cleanup.
> Please review and give comments.
>
> <snip patch>
This looks good. I have a few of comments:
- add read_lock_rcu() / read_unlock_rcu() around the loop in
notifier_call_chain() to be preempt-safe.
- I would suggest using struct list_head in the notifier_block
and use the RCU list routines from include/linux/list.h
instead of spreading subtle RCU memory-barrier black magic.
- Even though RCU list reading is lockless, premption needs to
be disabled while reading as mentioned above. So, we do
need an __notifier_call_chain() version for those handlers
that could sleep inside the handler: they will have to
handle the required locking themselves.
--
Vamsi Krishna S.
Linux Technology Center,
IBM Software Lab, Bangalore.
Ph: +91 80 5044959
Internet: vamsi@in.ibm.com
next prev parent reply other threads:[~2002-12-12 7:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-09 22:02 [PATCH] Notifier for significant events on i386 Stephen Hemminger
2002-12-11 11:21 ` Vamsi Krishna S .
2002-12-11 11:16 ` William Lee Irwin III
2002-12-11 11:43 ` Vamsi Krishna S .
2002-12-11 16:56 ` [lkcd-devel] " Stephen Hemminger
2002-12-11 20:27 ` John Levon
2002-12-11 21:15 ` Alan Cox
2002-12-12 0:19 ` Stephen Hemminger
2002-12-12 7:34 ` Vamsi Krishna S . [this message]
2002-12-12 17:53 ` Stephen Hemminger
2002-12-12 17:58 ` John Levon
2002-12-13 12:32 ` Vamsi Krishna S .
2002-12-12 8:13 ` Vamsi Krishna S .
2002-12-11 13:57 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021212130406.A20253@in.ibm.com \
--to=vamsi@in.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=levon@movementarian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox