* [PATCH] "extern inline" to "static inline" allows compile
@ 2002-12-12 23:09 Matt Reppert
2002-12-12 23:24 ` Richard Henderson
2002-12-13 0:18 ` Rusty Russell
0 siblings, 2 replies; 6+ messages in thread
From: Matt Reppert @ 2002-12-12 23:09 UTC (permalink / raw)
To: rth; +Cc: trivial, linux-kernel
Hi,
I can't compile 2.5.51 on an EV56 without this. Tested, boots.
There are a bunch of symbols in core_cia.h that break the build if they're
extern inline because they're only defined in the header now. Make them
static inline instead. (Important, since they're #defined to things like
inb)
Comments?
Matt
diff -Nru a/include/asm-alpha/core_cia.h b/include/asm-alpha/core_cia.h
--- a/include/asm-alpha/core_cia.h Thu Dec 12 16:59:06 2002
+++ b/include/asm-alpha/core_cia.h Thu Dec 12 16:59:06 2002
@@ -293,7 +293,7 @@
#ifdef __KERNEL__
#ifndef __EXTERN_INLINE
-#define __EXTERN_INLINE extern inline
+#define __EXTERN_INLINE static inline
#define __IO_EXTERN_INLINE
#endif
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] "extern inline" to "static inline" allows compile
2002-12-12 23:09 [PATCH] "extern inline" to "static inline" allows compile Matt Reppert
@ 2002-12-12 23:24 ` Richard Henderson
2002-12-12 23:44 ` Steffen Persvold
2002-12-13 0:18 ` Rusty Russell
1 sibling, 1 reply; 6+ messages in thread
From: Richard Henderson @ 2002-12-12 23:24 UTC (permalink / raw)
To: Matt Reppert; +Cc: trivial, linux-kernel
On Thu, Dec 12, 2002 at 05:09:02PM -0600, Matt Reppert wrote:
> Comments?
Revert the asm/pci.h change instead.
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] "extern inline" to "static inline" allows compile
2002-12-12 23:24 ` Richard Henderson
@ 2002-12-12 23:44 ` Steffen Persvold
2002-12-12 23:52 ` Richard Henderson
0 siblings, 1 reply; 6+ messages in thread
From: Steffen Persvold @ 2002-12-12 23:44 UTC (permalink / raw)
To: Richard Henderson; +Cc: Matt Reppert, trivial, linux-kernel
On Thu, 12 Dec 2002, Richard Henderson wrote:
> On Thu, Dec 12, 2002 at 05:09:02PM -0600, Matt Reppert wrote:
> > Comments?
>
> Revert the asm/pci.h change instead.
>
Is there a reason for the 'extern inline', to me it seems more natural to
have 'static inline' ?
Regards,
--
Steffen Persvold | Scali AS
mailto:sp@scali.com | http://www.scali.com
Tel: (+47) 2262 8950 | Olaf Helsets vei 6
Fax: (+47) 2262 8951 | N0621 Oslo, NORWAY
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] "extern inline" to "static inline" allows compile
2002-12-12 23:44 ` Steffen Persvold
@ 2002-12-12 23:52 ` Richard Henderson
0 siblings, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2002-12-12 23:52 UTC (permalink / raw)
To: Steffen Persvold; +Cc: Matt Reppert, trivial, linux-kernel
On Fri, Dec 13, 2002 at 12:44:17AM +0100, Steffen Persvold wrote:
> Is there a reason for the 'extern inline', to me it seems more natural to
> have 'static inline' ?
Yes. Examine the entire __EXTERN_INLINE structure with
core_foo.[ch].
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] "extern inline" to "static inline" allows compile
2002-12-12 23:09 [PATCH] "extern inline" to "static inline" allows compile Matt Reppert
2002-12-12 23:24 ` Richard Henderson
@ 2002-12-13 0:18 ` Rusty Russell
2002-12-13 9:24 ` Richard Henderson
1 sibling, 1 reply; 6+ messages in thread
From: Rusty Russell @ 2002-12-13 0:18 UTC (permalink / raw)
To: Matt Reppert; +Cc: rth, linux-kernel
In message <20021212170902.34e344b1.arashi@arashi.yi.org> you write:
> Hi,
>
> I can't compile 2.5.51 on an EV56 without this. Tested, boots.
> There are a bunch of symbols in core_cia.h that break the build if they're
> extern inline because they're only defined in the header now. Make them
> static inline instead. (Important, since they're #defined to things like
> inb)
>
> Comments?
This patch is simple, but not trivial, and since RTH wrote this, I'm
assuming all those __EXTERN_INLINE's are defined and undefned in
multiple places for a reason.
Richard?
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] "extern inline" to "static inline" allows compile
2002-12-13 0:18 ` Rusty Russell
@ 2002-12-13 9:24 ` Richard Henderson
0 siblings, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2002-12-13 9:24 UTC (permalink / raw)
To: Rusty Russell; +Cc: Matt Reppert, linux-kernel
On Fri, Dec 13, 2002 at 11:18:57AM +1100, Rusty Russell wrote:
> This patch is simple, but not trivial, and since RTH wrote this, I'm
> assuming all those __EXTERN_INLINE's are defined and undefned in
> multiple places for a reason.
Indeed.
> Richard?
Fixed properly by reverting the asm-alpha/pci.h patch
and including asm/io.h in drivers/scsi/sr_ioctl.c.
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-12-13 9:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-12 23:09 [PATCH] "extern inline" to "static inline" allows compile Matt Reppert
2002-12-12 23:24 ` Richard Henderson
2002-12-12 23:44 ` Steffen Persvold
2002-12-12 23:52 ` Richard Henderson
2002-12-13 0:18 ` Rusty Russell
2002-12-13 9:24 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox